Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add player.currentWidth and player.currentHeight* methods for getting computed style #3144

Closed
wants to merge 2 commits into from

Commits on Feb 27, 2016

  1. ## Description

    Add `player.currentWidth` and `player.currentHeight`* methods for getting computed style
    
    ## Specific Changes proposed
    API methods:
    
    Component
    Component.prototype.currentDimension(widthOrHeight) -> Number - It takes a string value of either width or height to return back the appropriate value
    Component.prototype.currentDimensions() -> Object{width: Number, height: Number} - Returns an object with width and height properties
    Component.prototype.currentHeight() -> Number - Delegates to Component#currentDimension to get back the height value
    Component.prototype.currentWidth() -> Number - Delegates to Component#currentDimension to get back the width value
    
    ## Requirements Checklist
    - [ X ] Feature implemented / Bug fixed
    - [ X ] If necessary, more likely in a feature request than a bug fix
      - [ X ] Unit Tests updated or fixed
      - [ ] Docs/guides updated
      - [ ] Example created ([starter template on JSBin](http://jsbin.com/axedog/edit?html,output))
    - [ ] Reviewed by Two Core Contributors
    Can Küçükyılmaz committed Feb 27, 2016
    Configuration menu
    Copy the full SHA
    b400e5a View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2016

  1. fix issues-3074 code style issues

    Can Küçükyılmaz committed Mar 4, 2016
    Configuration menu
    Copy the full SHA
    e2ab0ec View commit details
    Browse the repository at this point in the history