Add documentation to #2391 #2425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TextTrackList has a couple of event listeners that users rely on. By emulated the TextTrackList we can hopefully eliminate some of the friction that can occur during tech changes around the text track event handlers.
When switching techs, we want to clear out the old text tracks and then restore them using the currently appropriate tracks.
Add event listeners in the constructor. Remove event listeners in dispose. 'removetrack' listener needs to be removed asynchronously to make sure that we get all the events that are to be triggered.
Add comments to the text-track-list-converter functions. trackToJson was only used internally, so mark it with an underscore to indicate it's not necessarily a stable API.
|
See the #2391 for reviews |
| }); | ||
|
|
||
| test('should have removed tracks on dispose', function(assert) { | ||
| let done = assert.async(); |
There was a problem hiding this comment.
Getting "TypeError: assert.async is not a function". Master is broken for me.
|
Got the tests fixed by forcing qunit to update. npm wasn't doing it just with an npm install for some reason. I'm seeing a lot more "ERROR:" messages logged now. Not positive it's this one specifically but we need to get a handle on those.
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #2391 with documentation