Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time display by using scrubbing as a function #2411

Closed
wants to merge 2 commits into from
Closed

Fix time display by using scrubbing as a function #2411

wants to merge 2 commits into from

Conversation

nickygerritsen
Copy link
Contributor

this.player_.scrubbing is a function and thus this call should have () added. Currently this will always return the cached current time

@heff
Copy link
Member

heff commented Jul 28, 2015

Oh man, thanks for catching that.

I think we should be fixing that in remainingTime too, though it looks like we have more updating to do in that component. Would you mind fixing that comment either way?

// var time = (this.player_.scrubbing) ? this.player_.getCache().currentTime : this.player_.currentTime();

@nickygerritsen
Copy link
Contributor Author

Found another spot where scrubbing was used without calling the function in comments, so modified that one too

@heff
Copy link
Member

heff commented Jul 28, 2015

Awesome, thanks! Looks good to me.

@videojs/core-committers can one other person confirm and pull in?

Sent from mobile

@dmlap dmlap closed this in fe65ffa Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants