Fixed XML markup. #1702
Merged
Fixed XML markup. #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! |
heff
added a commit
that referenced
this pull request
Dec 2, 2014
Fixed Flash object tag markup for strict XML.
|
Good fix but people still use xhtml? :P |
heff
added a commit
that referenced
this pull request
Dec 2, 2014
|
@gkatsev Probably only me ;). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an invalid markup issue that is problematic for XHTML pages that imply strict XML parsing.
Attributes are appended afterwards with space after the attribute but not before it, so the resulted markups looks like this:
The space could be added elsewhere, but it's not worth adding it in a loop with additional string concatenation operation and larger script size.