Add test for manual time tracking and dispose #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure time and progress event synthesis is turned off after the tech is disposed.For videojs#1431.
|
So this is a test that shows something we need to fix? |
|
I think this is so it wont break in the future. I think the change that was shown in #1431 would break this test. |
|
Yes, it was mainly to add some additional test coverage. I created this test trying to reproduce #1431 and thought it would be a shame to throw away. |
|
Got it. Cool. |
heff
added a commit
that referenced
this pull request
Aug 27, 2014
Add test for manual time tracking and dispose
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure time and progress event synthesis is turned off after the tech is disposed. For #1431.