Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced webkitRequestFullScreen with webkitRequestFullscreen #1101

Merged
merged 1 commit into from
May 7, 2014
Merged

Replaced webkitRequestFullScreen with webkitRequestFullscreen #1101

merged 1 commit into from
May 7, 2014

Conversation

michelt
Copy link
Contributor

@michelt michelt commented Mar 20, 2014

reffered to issue #1100

@heff
Copy link
Member

heff commented Mar 24, 2014

Thanks! Have you tested this on both iOS and desktop Safari?

@mmcc mmcc changed the title Replaced webkitRequestFullScreen with webkitReplaceFullscreen Replaced webkitRequestFullScreen with webkitRequestFullscreen Apr 11, 2014
@heff heff mentioned this pull request Apr 18, 2014
Closed
@paruls
Copy link

paruls commented Apr 29, 2014

I tried this on both iOS (6.0.1) and desktop Safari with the sandbox setup. It looks good- I didn't run into any issues or errors

@heff heff merged commit 61eb54a into videojs:master May 7, 2014
@heff
Copy link
Member

heff commented May 7, 2014

Thanks!

@heff heff mentioned this pull request May 7, 2014
Closed
This was referenced Apr 7, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement needs: confirmation needs: more info Please make enough detailed information is added to be actionable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michelt @heff @paruls