Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VTTCue error in Chrome #5823

Closed
onigetoc opened this issue Feb 26, 2019 · 6 comments
Closed

VTTCue error in Chrome #5823

onigetoc opened this issue Feb 26, 2019 · 6 comments

Comments

@onigetoc
Copy link

VTTCue error in Chrome (Look like with Audio track options)
Video js error for some HLS video (Videojs 5 can play these video with the HLS Contrib plugin)

Uncaught TypeError: Failed to construct 'VTTCue': The provided double value is non-finite.

Error exemple HLS live video: https://rcavlive.akamaized.net/hls/live/664044/cancbft/master.m3u8
@RafalLukawiecki
Copy link

RafalLukawiecki commented Mar 10, 2019 •
edited
Loading

I am experiencing the same error, but in Firefox desktop and Chrome, also playing HLS. Plays in Safari. Video.js 6 played correctly, we are just assessing video.js 7, and this is something that just came up. Any clues welcome.

The message in Chrome is:
Uncaught TypeError: Failed to construct 'VTTCue': The provided double value is non-finite.

The message in Safari is:
TypeError: Argument 1 of VTTCue.constructor is not a finite floating-point value.

Error stacks refer to this section of code in video.js:
Screenshot 2019-03-10 at 18 16 01

gkatsev added a commit to videojs/http-streaming that referenced this issue Mar 20, 2019
@gkatsev
fix(id3): ignore unsupported id3 frames
54bda11 
When we get an unsupported id3 frame, we don't parse its time. This ends
up coming back to us as NaN in the timing for the frame. Instead of
trying to create a cue for this frame, ignore it whenever the time isn't
a number or when it isn't finite.

Fixes videojs/video.js#5823
@gkatsev gkatsev mentioned this issue Mar 20, 2019
Merged
@gkatsev
Copy link
Member

gkatsev commented Mar 20, 2019

I have a PR that should fix this: videojs/http-streaming#437
Unfortunately, I can't try the example above, it's giving me a 403.

@RafalLukawiecki
Copy link

See my comment in your PR, happy to test before the weekend using our media.

@RafalLukawiecki
Copy link

RafalLukawiecki commented Mar 20, 2019 •
edited
Loading

As I mentioned in the PR comment, your fix resolves the issue. Video now plays in both Chrome and Firefox (it was OK in Safari). Many thanks, can't wait to get back to further testing of video.js 7.

gkatsev added a commit to videojs/http-streaming that referenced this issue Mar 21, 2019
@gkatsev
fix(id3): ignore unsupported id3 frames (#437)
7040b7d 
When we get an unsupported id3 frame, we don't parse its time. This ends
up coming back to us as NaN in the timing for the frame. Instead of
trying to create a cue for this frame, ignore it whenever the time isn't
a number or when it isn't finite.

Fixes videojs/video.js#5823
gkatsev pushed a commit that referenced this issue Mar 21, 2019
@greenkeeper @gkatsev
fix(package): update @videojs/http-streaming to version 1.9.3 🚀 (#5883)
cd6ac9d 
Fixes #5823
@RafalLukawiecki
Copy link

@gkatsev, thanks for closing this issue. Just to confirm: do you still need me to host an externally available video stream for the purpose of testing this issue, or is that no longer needed? It means extra work, so I am happy not to have to do it, but if it helps, I will.

@gkatsev
Copy link
Member

gkatsev commented Mar 21, 2019

No, we're all set then, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@onigetoc @gkatsev @RafalLukawiecki