Avoid weird menu item tooltip title #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
approved these changes
Nov 14, 2017
|
@misteroneill cool, whats the process for repeating this for the 5.x branch, is there a separate master for 5x? |
|
@arski Yeah, open a new PR against the |
Merged
|
As the original author of this hack, this change definitely LGTM! |
OwenEdwards
approved these changes
Nov 15, 2017
gkatsev
added
confirmed
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gkatsev @misteroneill cc @luarmr I'd like to make this change to avoid having weird titles for the menu items in the player. You can easily reproduce the bug by keeping your mouse over any submenu item (caption language, video quality) on your own homepage e.g.
Note: Firefox just hides an empty-space tooltip, but this issue does pop up in Chrome, IE, likely others
before:
after:
