Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style MouseTimeDisplay #3645

Closed
chemoish opened this issue Sep 26, 2016 · 2 comments · Fixed by #4031
Closed

Fix style MouseTimeDisplay #3645

chemoish opened this issue Sep 26, 2016 · 2 comments · Fixed by #4031

Comments

@chemoish
Copy link
Member

Description

When hovering over the ProgressControl the MouseTimeDisplay activates outside of the expected boundary of the SeekBar.

I suspect it has to do with margin: 0 0.45em 0 0.45em; identified in https://github.com/videojs/video.js/blob/master/src/css/components/_slider.scss#L6 and possibly how parent element calculates the MouseTimeDisplay?

Steps to reproduce

  1. Go to http://videojs.com/
  2. Play video
  3. Attempt to hover to the edges of the SeekBar

Results

Expected

For the MouseTimeDisplay to be bound by the SeekBar.

Actual

image

Additional Information

Please include any additional information necessary here. Including the following:

versions

videojs

5.11.6

browsers

  • Chrome
  • Firefox
  • Safari

OSes

OSX 10.11.5
@chemoish
Copy link
Member Author

chemoish commented Sep 26, 2016 •
edited
Loading

Possibly, easy, but naive fix would be to update the ProgressControl to have the margin instead.

(Haven't investigated)

@gkatsev
Copy link
Member

gkatsev commented Sep 27, 2016

Huh, oops. Also, I'm thinking when we do a new major release for videojs we make the "keepToolstipsInside" option on the progress control be the default and only option, which, I think would also fix this issue.

@chemoish chemoish mentioned this issue Sep 29, 2016
Closed
6 tasks
@gkatsev gkatsev mentioned this issue Dec 5, 2016
Merged
2 tasks
misteroneill added a commit to misteroneill/video.js that referenced this issue Jan 19, 2017
@misteroneill
Eliminate keepTooltipsInside option and fix videojs#3645
9a574b4 
This eliminates the keepTooltipsInside option and fixes issue videojs#3645 by
forcing a limitation on the calculated position of the tooltip.
misteroneill added a commit to misteroneill/video.js that referenced this issue Feb 3, 2017
@misteroneill
Address videojs#3645 by using pixel margins
6c903e6
@misteroneill misteroneill mentioned this issue Feb 3, 2017
Merged
2 tasks
gkatsev pushed a commit that referenced this issue Feb 3, 2017
@misteroneill @gkatsev
fix: Progress holder gaps cause tooltips misalignment and time toolti…
be27f2a 
…p outlines (#4031)

* Address #3645 by using pixel margins
* Fix outlines

Fixes #3645
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gkatsev @chemoish