Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to npm install with git dependency vtt.js #1895

Closed
silverwind opened this issue Feb 25, 2015 · 7 comments
Closed

Unable to npm install with git dependency vtt.js #1895

silverwind opened this issue Feb 25, 2015 · 7 comments

Comments

@silverwind
Copy link

I'm unable to install video.js's dependencies with the latest update that pulls in the git dependency of vtt.js. The issue seems to be something about git itself, which is at the latest version provided by Cygwin. Same installation works fine on OS X. Here's the error:

npm ERR! Command failed: git -c core.longpaths=true clone C:\Users\silverwind\AppData\Roaming\npm-cache\_git-remotes\https-gith
ub-com-gkatsev-vtt-js-git-9a867bb9 C:\Users\SILVER~1\AppData\Local\Temp\npm-3612-ea415d7b\git-cache-aa2cb630bc7b\3ba274b332de18
7f7269f277733021be3dd1f5bd

And my versions:

$ npm -v
2.5.1
$ git --version
git version 2.1.4

Would it maybe be possible to publish vtt.js to npm to work around this, maybe under a dist-tag?

@heff
Copy link
Member

heff commented Feb 25, 2015

I don't totally understand the error that's happening there, but why might publishing to npm fix this? @gkatsev any insight?

@silverwind
Copy link
Author

@heff because npm dependencies are just tarball downloads, no git involved.

@heff
Copy link
Member

heff commented Feb 25, 2015

Ah, that makes sense. I think we might just be waiting on mozilla/vtt.js#338 to be merged in before we can point directly at that project. @gkatsev will have a better idea of where that's at, and if it's worth publishing his own branch.

@silverwind
Copy link
Author

You could also depend on a tarball link from GitHub like this:

  "dependencies": {
    "videojs-swf": "4.5.3",
    "vtt.js": "https://github.com/gkatsev/vtt.js/tarball/3ba274b332de187f7269f277733021be3dd1f5bd"
  }

silverwind added a commit to silverwind/video.js that referenced this issue Feb 28, 2015
@mmcc
Copy link
Member

mmcc commented Jul 25, 2015

Closing this based on the result of #1911

@mmcc mmcc closed this as completed Jul 25, 2015
@gkatsev
Copy link
Member

gkatsev commented Dec 9, 2015

Fixed by #2905

@silverwind
Copy link
Author

👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants