Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change techs to emit events instead of triggering them on the player #1485

Closed
heff opened this issue Sep 4, 2014 · 0 comments
Closed

Change techs to emit events instead of triggering them on the player #1485

heff opened this issue Sep 4, 2014 · 0 comments
Labels
confirmed enhancement
Milestone
Techs 2.0

Comments

@heff
Copy link
Member

heff commented Sep 4, 2014

We currently have a mixed model where the player sets/gets properties on a tech while the tech triggers events on the player. It would be a big change (so tech 2.0/ vjs 5.0) but I think it would make the definition of a tech much cleaner if the player instead listened for tech events. Open to other thoughts on that.

Related: #863 #1194
@heff heff added this to the Techs 2.0 milestone Sep 4, 2014
@mmcc mmcc added the confirmed label Nov 17, 2014
benjipott added a commit to benjipott/video.js that referenced this issue Feb 11, 2015
@benjipott
Tech change handler spam fixes videojs#882 videojs#1485 videojs#1505 v…
d7c7d38 
…ideojs#1484
@benjipott benjipott mentioned this issue Feb 11, 2015
Closed
benjipott added a commit to benjipott/video.js that referenced this issue Feb 11, 2015
@benjipott
Tech change handler spam fixes videojs#882 videojs#1485 videojs#1505 v…
6bfc50e 
…ideojs#1484
@eXon eXon mentioned this issue Apr 3, 2015
Open
@heff heff mentioned this issue Apr 4, 2015
Closed
@eXon eXon mentioned this issue Apr 22, 2015
Closed
8 tasks
@heff heff closed this as completed in e5595b1 May 6, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
confirmed enhancement
Projects
None yet
Milestone
Techs 2.0
Development

No branches or pull requests
2 participants
@heff @mmcc