move orientationClass logic into buildCSSClass

videojs · Jul 15, 2015 · c752fe3 · c752fe3
1 parent f2e4299
commit c752fe3
Showing 1 changed file with 8 additions and 14 deletions.
diff --git a/src/js/control-bar/volume-menu-button.js b/src/js/control-bar/volume-menu-button.js
@@ -55,7 +55,14 @@ class VolumeMenuButton extends MenuButton {
    * @method buildCSSClass
    */
   buildCSSClass() {
-    return `vjs-volume-menu-button ${super.buildCSSClass()} ${this.orientationClassName()}`;
+    let orientationClass = '';
+    if (!!this.options_.vertical) {
+      orientationClass = 'vjs-volume-menu-button-vertical';
+    } else {
+      orientationClass = 'vjs-volume-menu-button-horizontal';
+    }
+
+    return `vjs-volume-menu-button ${super.buildCSSClass()} ${orientationClass}`;
   }
 
   /**
@@ -81,19 +88,6 @@ class VolumeMenuButton extends MenuButton {
     return menu;
   }
 
-  /**
-   * Generates a class name with the appropriate orientation for the slider
-   *
-   * @method orientationClassName
-   */
-  orientationClassName() {
-    if (!!this.options_.vertical) {
-      return 'vjs-volume-menu-button-vertical';
-    }
-
-    return 'vjs-volume-menu-button-horizontal';
-  }
-
   /**
    * Handle click on volume menu and calls super
    *