-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: Reorder SASS styles to address deprecation (#8821)
## Description Some of the existing rules would be interpreted differently in a future version of SASS. In the current version, they trigger a deprecation warning. See https://sass-lang.com/documentation/breaking-changes/mixed-decls/ ## Specific Changes proposed Re-orders rules to maintain current output and remove warnings. The output of video-js.css and video-js.min.css remains the same. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
- Loading branch information
1 parent
c4007db
commit 57c27f8
Showing
3 changed files
with
15 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
.video-js .vjs-control.vjs-close-button { | ||
& .vjs-icon-placeholder { | ||
@extend .vjs-icon-cancel; | ||
} | ||
|
||
cursor: pointer; | ||
height: 3em; | ||
position: absolute; | ||
right: 0; | ||
top: 0.5em; | ||
z-index: 2; | ||
|
||
& .vjs-icon-placeholder { | ||
@extend .vjs-icon-cancel; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters