fix: Add lang attribute to player el, so that css :lang() is correct (#…

…4046)
videojs · Feb 15, 2017 · 17143fd · 17143fd
1 parent 7ab52d1
commit 17143fd
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/js/player.js b/src/js/player.js
@@ -586,6 +586,10 @@ class Player extends Component {
     Dom.prependTo(tag, el);
     this.children_.unshift(tag);
 
+    // Set lang attr on player to ensure CSS :lang() in consistent with player
+    // if it's been set to something different to the doc
+    this.el_.setAttribute('lang', this.language_);
+
     this.el_ = el;
 
     return el;

diff --git a/test/unit/player.test.js b/test/unit/player.test.js
@@ -1160,6 +1160,23 @@ QUnit.test('inherits language from parent element', function(assert) {
   }
 });
 
+QUnit.test('sets lang attribute on player el', function(assert) {
+  const fixture = document.getElementById('qunit-fixture');
+  const oldLang = fixture.getAttribute('lang');
+
+  fixture.setAttribute('lang', 'x-attr-test');
+  const player = TestHelpers.makePlayer();
+
+  assert.equal(player.el().getAttribute('lang'), 'x-attr-test', 'player sets lang attribute on self');
+
+  player.dispose();
+  if (oldLang) {
+    fixture.setAttribute('lang', oldLang);
+  } else {
+    fixture.removeAttribute('lang');
+  }
+});
+
 QUnit.test('should return correct values for canPlayType', function(assert) {
   const player = TestHelpers.makePlayer();