Changed keyup to keydown for more responive key listeners. closes #1545…

…, closes #1616
videojs · Nov 25, 2014 · 1211e6f · 1211e6f
1 parent 7642691
commit 1211e6f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/js/menu.js b/src/js/menu.js
@@ -111,7 +111,7 @@ vjs.MenuButton = vjs.Button.extend({
       this.hide();
     }
 
-    this.on('keyup', this.onKeyPress);
+    this.on('keydown', this.onKeyPress);
     this.el_.setAttribute('aria-haspopup', true);
     this.el_.setAttribute('role', 'button');
   }

diff --git a/src/js/slider.js b/src/js/slider.js
@@ -36,7 +36,7 @@ vjs.Slider.prototype.dispose = function() {
   vjs.off(document, 'mouseup', this.boundEvents.end, false);
   vjs.off(document, 'touchmove', this.boundEvents.move, false);
   vjs.off(document, 'touchend', this.boundEvents.end, false);
-
+  vjs.off(document, 'keydown', vjs.bind(this, this.onKeyPress));
   vjs.off(document, 'keyup', vjs.bind(this, this.onKeyPress));
 
   vjs.Component.prototype.dispose.call(this);
@@ -187,7 +187,7 @@ vjs.Slider.prototype.calculateDistance = function(event){
 };
 
 vjs.Slider.prototype.onFocus = function(){
-  vjs.on(document, 'keyup', vjs.bind(this, this.onKeyPress));
+  vjs.on(document, 'keydown', vjs.bind(this, this.onKeyPress));
 };
 
 vjs.Slider.prototype.onKeyPress = function(event){