Ensure that the done event is triggered even if the segment does not contain audio/video data
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woohoo! Thank you! |
gesinger
reviewed
Oct 16, 2018
| @@ -356,7 +356,7 @@ <h3>footer</h3> | |||
| prepareSourceBuffer(combined, outputType, function () { | |||
| console.log('appending...'); | |||
| window.vjsBuffer.appendBuffer(bytes); | |||
| video.play(); | |||
| // video.play(); | |||
There was a problem hiding this comment.
Were these meant to be commented out?
There was a problem hiding this comment.
Oops. Autoplay on an airplane with sound turned on. I can revert this, though I think its a bit annoying to keep the autoplay
There was a problem hiding this comment.
All of our automated tests have to be run with video.muted = true; to avoid autoplay restrictions breaking our tests. YMMV.
lib/mp4/transmuxer.js
Outdated
| } | ||
| if (flushSource !== 'VideoSegmentStream' && flushSource !== 'AudioSegmentStream') { | ||
| // Return because we haven't received a flush from a data-generating | ||
| // portion of the segment (meaning that we have only recieved meta-data |
|
@mjneil can you find a spare minute and add a test? |
|
The issue seems to still exist - was this PR abandoned or just postponed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #194
This PR also makes the output
typeof thedataevents more consistent. Ifremux === trueand both audio and video are specified as tracks in the PMT, the output type will always becombinedeven if the particular segment is missing audio or video data.This change primarily makes sure that the transmuxer doesn't get stuck in a state waiting for content that will never come. It doesn't necessarily guarantee the outputted fmp4 will play in the browser without issue because the init segment will say that the fragment will contain both tracks even if one has no data.
e.g. chrome://media-internals may have an error similar to