Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio only exclude #1565

Merged
merged 8 commits into from
Feb 5, 2025
Merged

Audio only exclude #1565

merged 8 commits into from
Feb 5, 2025

Conversation

dzianis-dashkevich
Copy link
Contributor

@dzianis-dashkevich dzianis-dashkevich commented Feb 4, 2025

Description

We might encounter situations when we have a main playlist with audio-only and video-only or muxed renditions. VHS does not support switching between audio-only and video-only or muxed, so we want to exclude audio-only renditions if we have renditions with video.

Specific Changes proposed

  • Exclude audio-only renditions if we detected renditions with video.
  • Enable use of networkInformation API by default.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@dzianis-dashkevich dzianis-dashkevich changed the title Audio only filter Audio only exclude Feb 5, 2025
@dzianis-dashkevich dzianis-dashkevich marked this pull request as ready for review February 5, 2025 00:15
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.99%. Comparing base (14ac65a) to head (47ae7c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1565      +/-   ##
==========================================
+ Coverage   83.96%   83.99%   +0.02%     
==========================================
  Files          44       44              
  Lines       11681    11699      +18     
  Branches     2611     2618       +7     
==========================================
+ Hits         9808     9826      +18     
  Misses       1873     1873              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. We definitely should not be including demuxed audio with video playlists.

@dzianis-dashkevich dzianis-dashkevich merged commit 1289dd4 into main Feb 5, 2025
15 checks passed
@dzianis-dashkevich dzianis-dashkevich deleted the audio-only-filter branch February 5, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants