Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clamp seekable end to start instead of 0 #1564

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

alex-barstow
Copy link
Contributor

Description

We clamped the calculated seekable end (the true seekable end minus the liveEdgeDelay) to 0 instead of the seekable start, which resulted in the possibility of having seekable ranges like [5, 0], where the end is less than the start.

Specific Changes proposed

We should clamp the calculated seekable end to the start instead of 0 to prevent this possibility.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.96%. Comparing base (fef62d9) to head (8bef6d1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1564   +/-   ##
=======================================
  Coverage   83.95%   83.96%           
=======================================
  Files          44       44           
  Lines       11683    11681    -2     
  Branches     2612     2611    -1     
=======================================
- Hits         9809     9808    -1     
+ Misses       1874     1873    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex-barstow alex-barstow merged commit 14ac65a into main Feb 3, 2025
15 checks passed
@alex-barstow alex-barstow deleted the fix/seekable-end-not-less-than-start branch February 3, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants