-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed dependencies #9
Conversation
Removed `angular` and `angular-sanitize` dependencies, as they break building project with Browserify if `angular` is bundled as a non-npm module (`Error: Cannot find module 'angular'`).
Accepted. Thanks for the suggestion. |
Similar to the following PR: videogular/bower-videogular#9. Placing angular as a dependency in `index.js` causes `WARNING: Tried to load angular more than once. Angular JS`.
@2fdevs, Is it possible to look into this again? I think the issue here was that the dependencies were not listed in The above link points to the I want to add videogular to the jspm registry via #726 and this is blocking videogular from being added to the registry. Re: the relevant comment. |
@whitneyit may be right. I took time to test if the removed lines from this PR break the build if I add them back and it looks like all works fine (tested with the latest Browserify). |
Ok, I'm going to add those lines again. Thanks @whitneyit for the warning and @piotrd for following the conversation :) |
@whitneyit I've updated the latest tag and the master branch. |
Can these changes also be applied to the other bower repos? Also, it appears that $ npm install --save angular angular-sanitize |
Yeah, sure! Should we add to other bower repos |
Yea that sounds like a good idea! |
Done! Sorry for taking so long in doing this! |
All good man thanks! |
Removed
angular
andangular-sanitize
dependencies, as they break building project with Browserify ifangular
is bundled as a non-npm module (Error: Cannot find module 'angular'
). Requiring these doesn't have to occur in a plugin, they are usually required somewhere in the app.