Fix AAC overflow when it occurs at ADTS header #4781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
littlespex
pushed a commit
to cbsinteractive/hls.js
that referenced
this pull request
Dec 9, 2022
With this, if you build Shaka Player with "-@cast", the UI will contain a dummy cast proxy that does not require the full cast system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix playback of HLS streams with MPEGTS segments when AAC overflow occurs within the ADTS header.
Why is this Pull Request needed?
Without this fix data is dropped before being appended which can lead to buffer/decoder corruption (see #4732).
Resolves issues:
Fixes #4732
Relates to #4506
Checklist