Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Failed to execute 'update' on 'MediaKeySession #4577

Conversation

hongfeih-es
Copy link
Contributor

This PR will...

Fix several uncaught drm exceptions when call load/unload frequently.

Why is this Pull Request needed?

keySession.update is called in a callback. And it will raise exception when trying to update keys which belong to closed key session:

Uncaught (in promise) DOMException: Failed to execute 'update' on 'MediaKeySession': The session is already closed.
    at https://hls-js.netlify.app/dist/hls.js:6259:18
    at EMEController._onLicenseRequestReadyStageChange (https://hls-js.netlify.app/dist/hls.js:6457:11)

Are there any points in the code the reviewer needs to double check?

No

Resolves issues:

#4576

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@itsjamie itsjamie merged commit 68f0cfb into video-dev:master May 23, 2022
@itsjamie
Copy link
Collaborator

Thank you!

@itsjamie itsjamie added this to the 1.2.0 milestone May 23, 2022
littlespex pushed a commit to cbsinteractive/hls.js that referenced this pull request Dec 9, 2022
@hongfeih-es hongfeih-es deleted the bugfix/DORIS-1144-mediakeysession-update branch April 26, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants