Fix raw duration computation when 'default_sample_duration' field is … #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…present in the moof fragment
|
Hi @robwalch can you please take a look at this PR? |
robwalch
reviewed
Apr 14, 2020
| @@ -342,7 +342,7 @@ export function getDuration (data, initData) { | |||
| sampleDuration = readUint32(tfhd, 8); | |||
| } | |||
| const sampleCount = readUint32(trun, 4); | |||
| rawDuration += sampleDuration * sampleCount; | |||
| rawDuration = sampleDuration * sampleCount; | |||
There was a problem hiding this comment.
@adrian-branescu - So the we only want the traf duration (or moof duration if traf does not have these flags set?). They are redundant?
robwalch
approved these changes
Apr 14, 2020
|
@adrian-branescu thanks for the contribution. Great fix. I've seen a lot of issues with this new duration parsing. I was even considering throwing out the duration parsed here if it's not within a second of the manifest duration (since I've seen it wildly off, but maybe this is why!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…present in the moof fragment
This PR will...
Fix bug that corrupts DTS & PTS for HLS fMP4 streams that have the 'default_sample_duration' field present inside the moof fragments.
This bug triggers a chain of problems that make impossible to buffer and play these kind of streams.
Checklist