-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SortedMerge
to use a PriorityQueue
#657
Update SortedMerge
to use a PriorityQueue
#657
Conversation
SortedMerge
to use a PriorityQueue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments are mostly style nits - if you could fix other single line blocks to not use {}
as well, that would be good. also, there's a build error, if you could look at that please.
Looks like Test.Async.EndsWithTest.EndsWithWithStrings has some intermittent timing issue? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #657 +/- ##
==========================================
- Coverage 95.60% 95.46% -0.14%
==========================================
Files 247 247
Lines 8806 8867 +61
Branches 1602 1620 +18
==========================================
+ Hits 8419 8465 +46
- Misses 193 210 +17
+ Partials 194 192 -2 ☔ View full report in Codecov by Sentry. |
Thanks! |
Fixes #654