Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SortedMerge to use a PriorityQueue #657

Merged

Conversation

danielearwicker
Copy link
Contributor

@danielearwicker danielearwicker commented May 4, 2024

Fixes #654

@viceroypenguin viceroypenguin changed the title #654 Sorted merge priority queue Update SortedMerge to use a PriorityQueue May 4, 2024
Copy link
Owner

@viceroypenguin viceroypenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments are mostly style nits - if you could fix other single line blocks to not use {} as well, that would be good. also, there's a build error, if you could look at that please.

Source/SuperLinq/SortedMerge.cs Outdated Show resolved Hide resolved
Source/SuperLinq/SortedMerge.cs Outdated Show resolved Hide resolved
Source/SuperLinq/SortedMerge.cs Outdated Show resolved Hide resolved
Source/SuperLinq/SortedMerge.cs Outdated Show resolved Hide resolved
@danielearwicker
Copy link
Contributor Author

Looks like Test.Async.EndsWithTest.EndsWithWithStrings has some intermittent timing issue?

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (ef180fd) to head (4553ec0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
- Coverage   95.60%   95.46%   -0.14%     
==========================================
  Files         247      247              
  Lines        8806     8867      +61     
  Branches     1602     1620      +18     
==========================================
+ Hits         8419     8465      +46     
- Misses        193      210      +17     
+ Partials      194      192       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viceroypenguin viceroypenguin merged commit e89f29d into viceroypenguin:master May 4, 2024
3 of 4 checks passed
@viceroypenguin
Copy link
Owner

Thanks!

@viceroypenguin viceroypenguin added this to the v6.1.0 milestone May 4, 2024
@danielearwicker danielearwicker deleted the SortedMergePriorityQueue branch May 4, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PriorityQueue implementation of SortedMergeBy
2 participants