Replace ArraySegment with ReadOnlySpan in Batch/Window buffered operators #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a Func delegate for ReadOnlySpan. - Replace ArraySegment with ReadOnlySpan in Batch/Window buffered operators. - Add new public methods to PublicAPI. - Add BreakingReadOnlySpanFunc in BreakingFunc file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #639 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 248 248
Lines 8648 8648
Branches 1592 1592
=======================================
Hits 8240 8240
Misses 217 217
Partials 191 191 ☔ View full report in Codecov by Sentry. |
Head0nF1re
commented
Feb 22, 2024
| @@ -25,18 +25,18 @@ public void BatchValidatesSize() | |||
|
|
|||
| _ = Assert.Throws<ArgumentOutOfRangeException>("size", | |||
There was a problem hiding this comment.
@viceroypenguin In BatchTests:
BatchValidatesSizevalidates the exceptions thrown whensizeis invalid. Should we do the same for the other arguments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #583
Done:
Add a Func-like delegate
ReadOnlySpanFuncforReadOnlySpansinceref structscan't be used as type parameter.Replace
ArraySegmentwithReadOnlySpaninBatch/Windowbuffered operators, sinceReadOnlySpanprovides a truly readonly view of the memory segment (the content of the buffer can't be modified).Add new public methods to
PublicAPI.Add
BreakingFunc.OfSpaninBreakingFuncfile and update tests.