-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rank overloads with OrderByDirection #620
Add Rank overloads with OrderByDirection #620
Conversation
- Add Rank overloads with OrderByDirection in SuperLinq and SuperLinqAsync. This allows the user to choose the ordering direction when ranking the sequence - Add new public methods to PublicAPI.Unshipped.txt
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #620 +/- ##
==========================================
+ Coverage 93.30% 93.34% +0.03%
==========================================
Files 242 248 +6
Lines 7767 7813 +46
Branches 1596 1604 +8
==========================================
+ Hits 7247 7293 +46
Misses 329 329
Partials 191 191 ☔ View full report in Codecov by Sentry. |
Forgot about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple minor fixes, and should be good to merge. thanks!
resolves #544
Source:
Add
Rank
overloads withOrderByDirection
inSuperLinq
andSuperLinqAsync
. This allows the user to choose the ordering directionwhen ranking the sequence
Add new public methods to
PublicAPI.Unshipped.txt
Tests:
Rank
andDenseRank
operator.Docs:
sortDirection
in new methods.