Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CommunityToolkit.Diagnostics #567

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Remove CommunityToolkit.Diagnostics #567

merged 6 commits into from
Nov 20, 2023

Conversation

viceroypenguin
Copy link
Owner

This PR removes CommunityToolkit.Diagnostics package from the SuperLinq libraries. net8 bcl includes new methods that replicate most of the core functionality SuperLinq relies on; this functionality is conditionally added to SuperLinq directly in net7-, etc.

@viceroypenguin viceroypenguin added this to the 5.4.0 milestone Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (79347f3) 92.88% compared to head (3916096) 93.00%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ce/SuperLinq/Collections/UpdatablePriorityQueue.cs 50.00% 6 Missing ⚠️
Source/SuperLinq.Async/Memoize.cs 50.00% 4 Missing ⚠️
Source/SuperLinq/Memoize.cs 75.00% 4 Missing ⚠️
Source/SuperLinq.Async/Publish.cs 57.14% 3 Missing ⚠️
Source/SuperLinq.Async/Share.cs 57.14% 3 Missing ⚠️
...nerator/SuperLinq.Generator.Generator/EquiZip.g.cs 90.90% 0 Missing and 3 partials ⚠️
Source/SuperLinq.Async/AssertCount.cs 66.66% 0 Missing and 1 partial ⚠️
Source/SuperLinq.Async/Join.MergeJoin.cs 0.00% 1 Missing ⚠️
Source/SuperLinq.Async/Random.cs 87.50% 1 Missing ⚠️
Source/SuperLinq/Join.MergeJoin.cs 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
+ Coverage   92.88%   93.00%   +0.12%     
==========================================
  Files         255      255              
  Lines        8080     8133      +53     
  Branches     1621     1619       -2     
==========================================
+ Hits         7505     7564      +59     
+ Misses        364      359       -5     
+ Partials      211      210       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viceroypenguin viceroypenguin merged commit cdc0e7e into master Nov 20, 2023
@viceroypenguin viceroypenguin deleted the remove-guard branch November 20, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant