Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some CollectionIterators #549

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Remove some CollectionIterators #549

merged 6 commits into from
Nov 9, 2023

Conversation

viceroypenguin
Copy link
Owner

This PR removes some CollectionIterators, which do not meet the correct mechanics of ICollection<>.

Fixes #548

@viceroypenguin viceroypenguin force-pushed the iterators branch 2 times, most recently from 2d1f782 to f7c848a Compare November 9, 2023 14:07
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b249e2) 91.84% compared to head (d9e1900) 91.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
- Coverage   91.84%   91.73%   -0.11%     
==========================================
  Files         255      255              
  Lines        8213     8094     -119     
  Branches     1643     1624      -19     
==========================================
- Hits         7543     7425     -118     
+ Misses        462      460       -2     
- Partials      208      209       +1     
Files Coverage Δ
Source/SuperLinq/Do.cs 100.00% <ø> (ø)
Source/SuperLinq/PreScan.cs 100.00% <100.00%> (ø)
Source/SuperLinq/Rank.cs 100.00% <ø> (ø)
Source/SuperLinq/Scan.cs 100.00% <100.00%> (ø)
Source/SuperLinq/ScanBy.cs 100.00% <100.00%> (ø)
Source/SuperLinq/ScanRight.cs 97.82% <100.00%> (-2.18%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viceroypenguin viceroypenguin merged commit ba6f936 into master Nov 9, 2023
@viceroypenguin viceroypenguin deleted the iterators branch November 9, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove some CollectionIterators
1 participant