Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CollectionIterator.CopyTo #504

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Improve CollectionIterator.CopyTo #504

merged 1 commit into from
Aug 31, 2023

Conversation

viceroypenguin
Copy link
Owner

@viceroypenguin viceroypenguin commented Aug 31, 2023

This PR updates CollectionIterator.CopyTo to use the SuperEnumerable.CopyTo method to copy data into the destination array. The code is essentially unchanged in most cases, but will provide some performance improvement if the sequence is a collection.

Fixes #503

@viceroypenguin viceroypenguin added this to the 6.0.0 milestone Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (00b21d4) 93.02% compared to head (cccf1ff) 93.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   93.02%   93.04%   +0.02%     
==========================================
  Files         249      249              
  Lines        8184     8184              
  Branches     1635     1635              
==========================================
+ Hits         7613     7615       +2     
+ Misses        358      356       -2     
  Partials      213      213              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viceroypenguin viceroypenguin merged commit 6364beb into master Aug 31, 2023
@viceroypenguin viceroypenguin deleted the fallbackifempty branch August 31, 2023 15:39
@viceroypenguin viceroypenguin modified the milestones: 6.0.0, 5.3.0 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FallbackIfEmptyCollectionIterator is missing CopyTo override
1 participant