Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ICollection<> error checking #462

Merged
merged 29 commits into from
May 26, 2023
Merged

Improve ICollection<> error checking #462

merged 29 commits into from
May 26, 2023

Conversation

viceroypenguin
Copy link
Owner

This PR adds additional ICollection<> and IList<> error checking for implementation methods. These methods should validate incoming arguments are valid. Many operators updated to address missing validation checks.

Fixes #460

@viceroypenguin viceroypenguin added this to the 5.1.0 milestone May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (933afe3) 91.40% compared to head (c16baf3) 91.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   91.40%   91.42%   +0.01%     
==========================================
  Files         245      245              
  Lines        7916     7932      +16     
  Branches     1609     1609              
==========================================
+ Hits         7236     7252      +16     
  Misses        462      462              
  Partials      218      218              
Impacted Files Coverage Δ
Source/SuperLinq/Insert.cs 100.00% <ø> (ø)
Source/SuperLinq/Sequence.cs 100.00% <ø> (ø)
Source/SuperLinq/AssertCount.cs 100.00% <100.00%> (ø)
Source/SuperLinq/CountDown.cs 100.00% <100.00%> (ø)
Source/SuperLinq/FillBackward.cs 98.00% <100.00%> (ø)
Source/SuperLinq/FillForward.cs 100.00% <100.00%> (ø)
...ator/SuperLinq.Generator.Generator/ZipLongest.g.cs 100.00% <100.00%> (ø)
...tor/SuperLinq.Generator.Generator/ZipShortest.g.cs 100.00% <100.00%> (ø)
Source/SuperLinq/Lag.cs 100.00% <100.00%> (ø)
Source/SuperLinq/Lead.cs 100.00% <100.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@viceroypenguin viceroypenguin merged commit bad12b0 into master May 26, 2023
@viceroypenguin viceroypenguin deleted the error-checking branch May 26, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review ListIterator and CollectionIterator for Error-checking consistency
1 participant