Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do: ICollection<> implementation #383

Merged
merged 1 commit into from
May 6, 2023
Merged

Do: ICollection<> implementation #383

merged 1 commit into from
May 6, 2023

Conversation

viceroypenguin
Copy link
Owner

This PR adds an ICollection<> implementation of the Do and Pipe operators.

Fixes #381
Fixes #382

@viceroypenguin viceroypenguin added this to the 5.1.0 milestone May 6, 2023
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage: 96.96% and project coverage change: -0.01 ⚠️

Comparison is base (94644cc) 87.42% compared to head (556e8c1) 87.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
- Coverage   87.42%   87.42%   -0.01%     
==========================================
  Files         239      239              
  Lines        7175     7189      +14     
  Branches     1672     1675       +3     
==========================================
+ Hits         6273     6285      +12     
- Misses        462      463       +1     
- Partials      440      441       +1     
Impacted Files Coverage Δ
Source/SuperLinq/Do.cs 97.67% <96.87%> (-2.33%) ⬇️
Source/SuperLinq/Pipe.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@viceroypenguin viceroypenguin merged commit 0cd4e5a into master May 6, 2023
@viceroypenguin viceroypenguin deleted the do-icollection branch May 6, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICollection<T> version of Do ICollection<T> version of Pipe
1 participant