Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Finally operator #334

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

viceroypenguin
Copy link
Owner

@viceroypenguin viceroypenguin commented Apr 12, 2023

This PR copies the Finally operator from SuperLinq and adapts to an async operator.

Fixes #316

@viceroypenguin viceroypenguin added this to the 5.0.0 milestone Apr 12, 2023
@viceroypenguin viceroypenguin linked an issue Apr 12, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.03 ⚠️

Comparison is base (d353b3a) 87.43% compared to head (8cae92c) 87.40%.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           replace-System.Interactive.Async     #334      +/-   ##
====================================================================
- Coverage                             87.43%   87.40%   -0.03%     
====================================================================
  Files                                   230      231       +1     
  Lines                                  6723     6731       +8     
  Branches                               1550     1554       +4     
====================================================================
+ Hits                                   5878     5883       +5     
  Misses                                  447      447              
- Partials                                398      401       +3     
Impacted Files Coverage Δ
Source/SuperLinq.Async/Finally.cs 62.50% <62.50%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@viceroypenguin viceroypenguin merged commit 23e10c8 into replace-System.Interactive.Async Apr 12, 2023
@viceroypenguin viceroypenguin deleted the finally branch April 12, 2023 13:44
viceroypenguin added a commit that referenced this pull request Apr 26, 2023
* Update doc reference away from System.Interactive.Async

* Remove `System.Interactive.Async` w/ placeholders

* Add `Memoize` operator (#279)

* Add `Repeat` operator (#280)

* Add `Do` operator (#281)

* Add `Case` operator (#284)

* Add `If` operator (#285)

* Add `ForEach` operator (#287)

* Add `Batch` operator (#289)

* Add `Buffer` operator (#291)

* Rename `ScanEx` back to `Scan` (#295)

* Add `MinByWithTies` and `MaxByWithTies` (#298)

* Add `DistinctUntilChanged` operator (#305)

* Add `While` operator (#308)

* Add `DoWhile` operator (#328)

* Correct testing code for async `While`

* Add `Throw` operator (#330)

* Address build warning

* Add `Finally` operator (#334)

* Add `Catch` operator (#335)

* Add `Defer` operator (#336)

* Add `Retry` operator (#338)

* Add `Using` operator (#339)

* Add `Return` operator (#340)

* Add `OnErrorResumeNext` operator (#341)

* Correct missing `.ConfigureAwait()` in `Memoize()`

* Correct `TestingSequence` to match sync version

* Add `Share` operator (#343)

* Add `Publish` operator (#342)

* Add `Timeout` operator (#348)

* Add `Amb` operator (#351)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Replace System.Interactive.Async) Finally
1 participant