- added cyclic ref check

viant · Feb 20, 2025 · 0880032 · 0880032
1 parent fc52466
commit 0880032
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/io/load/reader/csv/csv.go b/io/load/reader/csv/csv.go
@@ -27,6 +27,7 @@ type (
 		references      map[string][]string
 		pathAccessors   map[string]*xunsafe.Field
 		stringifiers    map[reflect.Type]*io2.ObjectStringifier
+		uniqueTypes     map[reflect.Type]bool
 		config          *Config
 	}
 
@@ -87,6 +88,7 @@ func NewMarshaller(rType reflect.Type, config *Config) (*Marshaller, error) {
 		references:      map[string][]string{},
 		pathAccessors:   map[string]*xunsafe.Field{},
 		xType:           xunsafe.NewType(elemType),
+		uniqueTypes:     map[reflect.Type]bool{},
 	}
 
 	if err := marshaller.init(config, excluded); err != nil {
@@ -106,6 +108,11 @@ func (m *Marshaller) init(config *Config, excluded map[string]bool) error {
 }
 
 func (m *Marshaller) indexByPath(parentType reflect.Type, path string, excluded map[string]bool, holder string, parentAccessor *xunsafe.Field) {
+	if m.uniqueTypes[parentType] { //avoid cyclic reference
+		return
+	}
+	m.uniqueTypes[parentType] = true
+
 	elemParentType := Elem(parentType)
 	numField := elemParentType.NumField()
 	m.pathAccessors[path] = parentAccessor