RSDK-1979 add motion service #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpertsov
force-pushed
the
RSDK-1979-motion
branch
from
09c6b91 to
438dcaa
Compare
maximpertsov
commented
Apr 11, 2023
| return { | ||
| x: proto.getX(), | ||
| y: proto.getY(), | ||
| z: proto.getZ(), | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
maximpertsov
commented
Apr 11, 2023
| import pb from '../../gen/service/motion/v1/motion_pb'; | ||
|
|
||
| export type MotionConstraints = pb.Constraints.AsObject; | ||
|
|
There was a problem hiding this comment.
Most of the code below will go away once we migrate to protobuf-es since that library generate protobuf structures that are essentially plain objects. for now we need to have custom functions to convert from objects -> protos.
|
I tested these changes against a live arm. Unfortunately we actually use the motionApi yet so we might have to wait for it to be developed more to test that wrapper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://viam.atlassian.net/browse/RSDK-1979
AsObjectinterface. Sadly these is no built-infromObjectmethod so we have to write functions for this.