RSDK-9755 - CLI lint enforce createCommandWithT usage #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
requested review from
a team,
purplenicole730 and
lia-viam
and removed request for
a team
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
njooma
approved these changes
Feb 24, 2025
.github/workflows/test.yml
Outdated
| @@ -76,6 +76,12 @@ jobs: | |||
| sudo apt-get update && sudo apt-get install -y python3-venv | |||
| sudo --preserve-env=MONGODB_TEST_OUTPUT_URI,GITHUB_SHA,GITHUB_RUN_ID,GITHUB_RUN_NUMBER,GITHUB_RUN_ATTEMPT,GITHUB_X_PR_BASE_SHA,GITHUB_X_PR_BASE_REF,GITHUB_X_HEAD_REF,GITHUB_X_HEAD_SHA,GITHUB_REPOSITORY -Hu testbot bash -lc 'make test-go' | |||
|
|
|||
| - name: Run CLI linter tests | |||
There was a problem hiding this comment.
Maybe lint before running unit tests?
Unit tests take forever, and linting should be fast
viambot
added
safe to test
abe-winter
pushed a commit
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a linter step that verifies that all CLI actions are generated with the
createCommandWithThelper function.Tested locally, observed expected linter failure when commands (of the
Action,Before, orAftervariety) were generated without use ofcreateCommandWithT.Note that I have not removed @viamrobotics/sdk-netcode as a codeowner for
cli/app.go. I know that doing so is a goal but I opted for the more conservative approach for now, while we confirm that no additional linter rules are necessary. I don't feel strongly about this though; happy to revisit if anyone else does.