[RSDK-5526] - Make webcam driver detection debugging better #4794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
safe to test
viambot
added
safe to test
hexbabe
commented
Feb 14, 2025
| @@ -133,16 +134,22 @@ func selectBestDriver( | |||
|
|
|||
| baseDrivers := driver.GetManager().Query(baseFilter) | |||
| logger.Debugw("before specific filter, we found the following drivers", "count", len(baseDrivers)) | |||
| for _, d := range baseDrivers { | |||
| logger.Debugw(d.Info().Label, "priority", float32(d.Info().Priority), "type", d.Info().DeviceType) | |||
| for i, d := range baseDrivers { | |||
There was a problem hiding this comment.
more info for base drivers (pre-filter)
hexbabe
commented
Feb 14, 2025
| logger.Debugw("found no drivers matching filter") | ||
| } else { | ||
| logger.Debugw("found drivers matching specific filter", "count", len(driverProperties)) | ||
| return nil, prop.Media{}, errors.New("found no queryable drivers matching filter") |
There was a problem hiding this comment.
not sure why we don't return immediately before. It makes the error less clear.
hexbabe
commented
Feb 14, 2025
| @@ -203,14 +216,14 @@ func queryDriverProperties( | |||
| if isAvailable { | |||
| err := d.Open() | |||
| if err != nil { | |||
| logger.Debugw("error opening driver for querying", "error", err) | |||
| logger.Infow("error trying to open driver for querying", "error", err) | |||
There was a problem hiding this comment.
these should be info logs since they include valuable information such as IO errors when accessing the driver for query
randhid
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.