Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-9972 Update server tunnel to connect to 127.0.0.1 instead of localhost #4791

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

benjirewis
Copy link
Member

Still need to talk with @abe-winter about why this might be necessary, and double check that everything still actually works (tests still seem to pass.)

@benjirewis benjirewis requested a review from cheukt February 13, 2025 17:00
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Feb 13, 2025
Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to merge after convo, or after any other changes arising from that convo.

@benjirewis benjirewis added the static-build Build static binaries from PR label Feb 13, 2025
@cheukt cheukt added static-ignore-tests Build static binaries from PR and ignore tests safe to test This pull request is marked safe to test from a trusted zone and removed static-build Build static binaries from PR static-ignore-tests Build static binaries from PR and ignore tests safe to test This pull request is marked safe to test from a trusted zone labels Feb 13, 2025
@benjirewis benjirewis merged commit b9b69ef into viamrobotics:main Feb 13, 2025
52 checks passed
@benjirewis benjirewis deleted the no-localhost-tunnel branch February 13, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants