[RSDK-3154] Switch to BuildJet for arm64 action runners #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
edaniels
approved these changes
May 19, 2023
| @@ -120,15 +116,12 @@ jobs: | |||
| - name: Check out main branch code | |||
| if: github.event_name != 'pull_request_target' | |||
| uses: actions/checkout@v3 | |||
| with: | |||
| fetch-depth: 2 | |||
|
|
|||
| - name: Check out PR branch code | |||
| if: github.event_name == 'pull_request_target' | |||
| uses: actions/checkout@v3 | |||
| with: | |||
| ref: ${{ github.event.pull_request.head.sha }} | |||
There was a problem hiding this comment.
did you check if this affects coverage?
There was a problem hiding this comment.
Added "test_cmd" to the Test step so amd64 runs cover/test-web, and arm64 does test-go/test-web instead.
viambot
added
safe to test
viambot
removed
the
safe to test
viambot
added
the
safe to test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to BuildJet for arm64 action runners in github, instead of relying on our own hardware/emulation for it. It also starts running the FULL test suite on arm64 as well as amd64. The speed of actual tests is roughly equivalent between amd64 and arm64 (with arm64 sometimes even being faster than our own amd64 runners), but buildjet takes a little extra time to download and fire up our docker image at the start of a job, so there's some overhead. A full lint/test/build/deploy run is about 12% slower overall (90-120 seconds.) Doubling the VM size (cpu count) only shaves 40 seconds off things overall, so isn't worth doubling the price IMHO.
Billing for buildjet is currently set to my Expensify card. The buildjet account itself associates directly with the github organization, so I believe any/all admins here should also have access there (I certainly never created any other login.)