RSDK-2725 Support debug logging for modules #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
benjirewis
commented
May 16, 2023
|
|
||
| // NewInfoObservedTestLogger is a copy of NewObservedTestLogger with info level | ||
| // debugging instead of debug level. | ||
| func NewInfoObservedTestLogger(tb testing.TB) (golog.Logger, *observer.ObservedLogs) { |
There was a problem hiding this comment.
@erd I can move this to golog, but I wasn't sure how useful it was/whether it was even necessary.
viambot
added
safe to test
benjirewis
commented
May 17, 2023
Otterverse
requested changes
May 17, 2023
There was a problem hiding this comment.
So I suggested simplifying the new log constructor to never fail, which should simplify its use as well. My main concern is the new Debug option in the config struct doesn't have the proto/conversion code to actually be passed through from the cloud. Other notes inline.
viambot
added
safe to test
Otterverse
requested changes
May 22, 2023
There was a problem hiding this comment.
Very minor things in what's here, noted inline, but you still need to update config/proto_conversions.go (and related tests) for the new field in module config, which will mean you also need to bump the version of API in go.mod to include your recent updates there.
viambot
removed
the
safe to test
viambot
added
the
safe to test
benjirewis
force-pushed
the
RSDK-2725-module-debugging
branch
from
50a542b to
b657c05
Compare
viambot
added
safe to test
|
Otterverse
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSDK-2725
Adds
LogLeveltoconfig.Module. Adds logic to pass alog-levelcommandline argument to the module executable ifLogLevelis set on the module orLogLevelis unset on the module but module manager log level isDebug. Adds helpermodule.NewLoggerFromArgsto help create a debug or non-debug module based on whether--log-level=debugis the third argument inos.Args. Updates complexmodule example to have"log_level": "debug"and usemodule.NewLoggerFromArgs.Adds
NewInfoObserverTestLoggertest utility to make an observed test logger atInfolevel (instead of the defaultDebug). Adds test to ensurelog_levelis passed correctly to module. Adds test to ensure module can start withoutLogLeveland be reconfigured to have it. Modifies testmodule to usemodule.NewLoggerFromArgsand log a debug message: "debug mode enabled".