RSDK-3027 - implement resource.Named for vision service models #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
viambot
added
safe to test
|
Note: merge base coverage results not available, comparing against closest 627dd95~2=(a7318eb) instead
|
edaniels
approved these changes
May 11, 2023
| @@ -94,7 +96,7 @@ func NewService( | |||
| "model %q does not fulfill any method of the vision service. It is neither a detector, nor classifier, nor 3D segmenter", name) | |||
| } | |||
| return &vizModel{ | |||
| name: name, | |||
| Named: name.AsNamed(), | |||
Rob1in
approved these changes
May 11, 2023
bazile-clyde
pushed a commit
to bazile-clyde/rdk
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All vision service models did not actually implement the
resource.Namedinterface, and had left it nil. This caused a nil pointer de-reference whenever "Name()" was called on any vision service resource.Manually tested out the fixes with the QA plan for the color detector that originally found the error, and it now works.