Add async cancellable scheduling function #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
|
mcous
approved these changes
May 4, 2023
| const refreshAndScheduleNext = async () => { | ||
| await callback(); | ||
|
|
||
| // eslint-disable-next-line no-use-before-define |
There was a problem hiding this comment.
Happily enough, the common JS config will remove the need for this override by configuring the no-use-before-define rule to only complain about actual errors
| @@ -0,0 +1,28 @@ | |||
| export const scheduleAsyncPoll = (callback: () => Promise<void>, interval: number) => { | |||
| let cancelled = false; | |||
| let timeoutId = -1; | |||
There was a problem hiding this comment.
IIRC the typescript types allow undefined for clearTimeout (and it's certainly allowed at runtime) so I softly prefer that to a -1 magic value for "not set"
Comment on lines
+13
to
+17
| if (cancelled) { | ||
| return; | ||
| } | ||
|
|
||
| timeoutId = window.setTimeout(refreshAndScheduleNext, interval); |
There was a problem hiding this comment.
Maybe rather than an early return, purely stylistic
Suggested change
| if (cancelled) { | |
| return; | |
| } | |
| timeoutId = window.setTimeout(refreshAndScheduleNext, interval); | |
| if (!cancelled) { | |
| timeoutId = window.setTimeout(refreshAndScheduleNext, interval); | |
| } |
| return displayError(error as ServiceError); | ||
| } | ||
| rcLogConditionally(request); | ||
| props.client.encoderService.getProperties(request, new grpc.Metadata(), (error, response) => { |
There was a problem hiding this comment.
Seems like a good candidate for a promisification helper in a future PR
There was a problem hiding this comment.
Yeah, I think as a next step I'd like to start moving these out into an api folder that promisifies all these callback apis. Quarantine zones FTW!
bazile-clyde
pushed a commit
to bazile-clyde/rdk
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new util,
scheduleAsyncPoll, which schedules a clearable timeout for an async polling function. It also introduces better practices for polling in the Encoder card:I'll update other components in a follow-up PR.