Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DATA-1351]: Update CLI tool BE #2290

Merged
merged 1 commit into from
Apr 27, 2023
Merged

[DATA-1351]: Update CLI tool BE #2290

merged 1 commit into from
Apr 27, 2023

Conversation

tahiyasalam
Copy link
Member

Context
CLI string in the FE was updated to include --bboxLabel, but not the BE, so the export command will fail if you copy and paste in with --bboxLabel. This updates the cli tool to include the flag bbox_labels since this is following the convention for all other cli flags. FE will need to be updated accordingly.

Testing
Testing locally by building go build -o ~/go/bin/viam cli/viam/main.go and then exporting:
viam --base-url=https://app.viam.dev:443 data export --bbox_labels=blue_square,blue_star,brown_circle,green_square,orange_triangle,pink_star,pink_triangle,yellow_circle --org_ids=0fbe951e-d4c6-427f-985f-784b7b85842c --data_type=binary --mime_types=image/jpeg,image/png --destination=exported_data

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Apr 27, 2023
agreenb
agreenb approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@agreenb agreenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding!

@tahiyasalam tahiyasalam changed the title [DATA-1351]: Update CLI tool [BE+FE] [DATA-1351]: Update CLI tool BE Apr 27, 2023
alexis-wei
alexis-wei approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@alexis-wei alexis-wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me! 🥇
Would be great if you can either make the app update right after this to add the s or make a ticket for it!

@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Delta Health
go.viam.com/rdk/components/arm 64% 0.00% ➖
go.viam.com/rdk/components/arm/fake 29% 0.00% ❌
go.viam.com/rdk/components/arm/universalrobots 41% 0.00% ❌
go.viam.com/rdk/components/arm/wrapper 21% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 23% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 6% 0.00% ❌
go.viam.com/rdk/components/audioinput 43% -0.47% ❌
go.viam.com/rdk/components/base 41% 0.00% ❌
go.viam.com/rdk/components/base/agilex 63% 0.00% ➖
go.viam.com/rdk/components/base/boat 40% 0.00% ❌
go.viam.com/rdk/components/base/fake 52% 0.00% ➖
go.viam.com/rdk/components/base/wheeled 75% 0.00% ✅
go.viam.com/rdk/components/board 60% -0.21% ➖
go.viam.com/rdk/components/board/fake 40% 0.00% ❌
go.viam.com/rdk/components/board/genericlinux 20% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi 50% 0.00% ➖
go.viam.com/rdk/components/camera 57% 0.00% ➖
go.viam.com/rdk/components/camera/align 58% 0.00% ➖
go.viam.com/rdk/components/camera/fake 74% 0.00% ✅
go.viam.com/rdk/components/camera/ffmpeg 82% 0.00% ✅
go.viam.com/rdk/components/camera/rtsp 46% +0.88% ❌
go.viam.com/rdk/components/camera/transformpipeline 77% 0.00% ✅
go.viam.com/rdk/components/camera/videosource 34% 0.00% ❌
go.viam.com/rdk/components/encoder 57% 0.00% ➖
go.viam.com/rdk/components/encoder/ams 64% 0.00% ➖
go.viam.com/rdk/components/encoder/fake 83% 0.00% ✅
go.viam.com/rdk/components/encoder/incremental 80% 0.00% ✅
go.viam.com/rdk/components/encoder/single 86% 0.00% ✅
go.viam.com/rdk/components/gantry 56% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 87% 0.00% ✅
go.viam.com/rdk/components/gantry/oneaxis 87% 0.00% ✅
go.viam.com/rdk/components/generic 79% 0.00% ✅
go.viam.com/rdk/components/gripper 69% 0.00% ➖
go.viam.com/rdk/components/input 88% 0.00% ✅
go.viam.com/rdk/components/input/fake 93% 0.00% ✅
go.viam.com/rdk/components/input/gpio 85% 0.00% ✅
go.viam.com/rdk/components/motor 71% 0.00% ✅
go.viam.com/rdk/components/motor/dimensionengineering 65% 0.00% ➖
go.viam.com/rdk/components/motor/dmc4000 70% 0.00% ✅
go.viam.com/rdk/components/motor/fake 53% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 59% +1.01% ➖
go.viam.com/rdk/components/motor/gpiostepper 52% 0.00% ➖
go.viam.com/rdk/components/motor/tmcstepper 64% 0.00% ➖
go.viam.com/rdk/components/motor/ulnstepper 53% 0.00% ➖
go.viam.com/rdk/components/movementsensor 76% 0.00% ✅
go.viam.com/rdk/components/movementsensor/adxl345 66% 0.00% ➖
go.viam.com/rdk/components/movementsensor/cameramono 41% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 51% 0.00% ➖
go.viam.com/rdk/components/movementsensor/gpsrtk 29% +1.24% ❌
go.viam.com/rdk/components/movementsensor/mpu6050 84% 0.00% ✅
go.viam.com/rdk/components/posetracker 71% 0.00% ✅
go.viam.com/rdk/components/sensor 52% 0.00% ➖
go.viam.com/rdk/components/sensor/ultrasonic 43% 0.00% ❌
go.viam.com/rdk/components/servo 62% 0.00% ➖
go.viam.com/rdk/components/servo/gpio 72% 0.00% ✅
go.viam.com/rdk/config 79% 0.00% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 77% 0.00% ✅
go.viam.com/rdk/examples/customresources/demos/remoteserver 0% 0.00% ❌
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/internal/cloud 100% 0.00% ✅
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 71% 0.00% ✅
go.viam.com/rdk/module 76% 0.00% ✅
go.viam.com/rdk/module/modmanager 80% 0.00% ✅
go.viam.com/rdk/motionplan 71% +0.34% ✅
go.viam.com/rdk/operation 82% 0.00% ✅
go.viam.com/rdk/pointcloud 69% +0.07% ➖
go.viam.com/rdk/protoutils 49% 0.00% ❌
go.viam.com/rdk/referenceframe 72% 0.00% ✅
go.viam.com/rdk/resource 75% 0.00% ✅
go.viam.com/rdk/rimage 77% 0.00% ✅
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 75% 0.00% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 86% 0.00% ✅
go.viam.com/rdk/robot/client 82% 0.00% ✅
go.viam.com/rdk/robot/framesystem 67% 0.00% ➖
go.viam.com/rdk/robot/impl 82% 0.00% ✅
go.viam.com/rdk/robot/packages 80% 0.00% ✅
go.viam.com/rdk/robot/server 53% 0.00% ➖
go.viam.com/rdk/robot/web 64% 0.00% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol 50% 0.00% ➖
go.viam.com/rdk/services/baseremotecontrol/builtin 82% 0.00% ✅
go.viam.com/rdk/services/datamanager 65% 0.00% ➖
go.viam.com/rdk/services/datamanager/builtin 85% -0.49% ✅
go.viam.com/rdk/services/datamanager/datacapture 73% 0.00% ✅
go.viam.com/rdk/services/datamanager/datasync 0% 0.00% ❌
go.viam.com/rdk/services/mlmodel 83% 0.00% ✅
go.viam.com/rdk/services/mlmodel/tflitecpu 83% 0.00% ✅
go.viam.com/rdk/services/motion 51% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 85% 0.00% ✅
go.viam.com/rdk/services/navigation 53% 0.00% ➖
go.viam.com/rdk/services/sensors 81% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 95% 0.00% ✅
go.viam.com/rdk/services/shell 11% 0.00% ❌
go.viam.com/rdk/services/slam 93% 0.00% ✅
go.viam.com/rdk/services/slam/fake 90% 0.00% ✅
go.viam.com/rdk/services/vision 35% 0.00% ❌
go.viam.com/rdk/services/vision/colordetector 56% 0.00% ➖
go.viam.com/rdk/services/vision/detectionstosegments 67% 0.00% ➖
go.viam.com/rdk/services/vision/mlvision 70% 0.00% ➖
go.viam.com/rdk/services/vision/radiusclustering 59% 0.00% ➖
go.viam.com/rdk/session 97% 0.00% ✅
go.viam.com/rdk/spatialmath 84% 0.00% ✅
go.viam.com/rdk/utils 71% 0.00% ✅
go.viam.com/rdk/vision 26% 0.00% ❌
go.viam.com/rdk/vision/chess 80% 0.00% ✅
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 82% 0.00% ✅
go.viam.com/rdk/vision/odometry 60% 0.00% ➖
go.viam.com/rdk/vision/odometry/cmd 0% 0.00% ❌
go.viam.com/rdk/vision/segmentation 49% 0.00% ❌
go.viam.com/rdk/web/server 26% 0.00% ❌
Summary 65% (21491 / 32941) +0.07% ➖

@tahiyasalam tahiyasalam merged commit b03f923 into viamrobotics:main Apr 27, 2023
bazile-clyde pushed a commit to bazile-clyde/rdk that referenced this pull request Jan 5, 2024
@tahiyasalam
[DATA-1351]: Update CLI tool BE (viamrobotics#2290)
c14d92e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agreenb agreenb agreenb approved these changes

@alexis-wei alexis-wei alexis-wei approved these changes

@AaronCasas AaronCasas Awaiting requested review from AaronCasas

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tahiyasalam @agreenb @alexis-wei @viambot