Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit: switch to bool #2278

Merged
merged 1 commit into from
Apr 25, 2023
Merged

nit: switch to bool #2278

merged 1 commit into from
Apr 25, 2023

Conversation

bazile-clyde
Copy link
Contributor

@edaniels missed this in #2276. Tested it works.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Apr 25, 2023
@bazile-clyde bazile-clyde requested a review from edaniels April 25, 2023 16:02
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Delta Health
go.viam.com/rdk/components/arm 64% 0.00% ➖
go.viam.com/rdk/components/arm/fake 29% 0.00% ❌
go.viam.com/rdk/components/arm/universalrobots 41% 0.00% ❌
go.viam.com/rdk/components/arm/wrapper 21% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 23% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 6% 0.00% ❌
go.viam.com/rdk/components/audioinput 44% +0.47% ❌
go.viam.com/rdk/components/base 41% 0.00% ❌
go.viam.com/rdk/components/base/agilex 63% 0.00% ➖
go.viam.com/rdk/components/base/boat 40% 0.00% ❌
go.viam.com/rdk/components/base/fake 52% 0.00% ➖
go.viam.com/rdk/components/base/wheeled 75% 0.00% ✅
go.viam.com/rdk/components/board 60% +0.21% ➖
go.viam.com/rdk/components/board/fake 40% 0.00% ❌
go.viam.com/rdk/components/board/genericlinux 20% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi 50% 0.00% ➖
go.viam.com/rdk/components/camera 57% 0.00% ➖
go.viam.com/rdk/components/camera/align 58% 0.00% ➖
go.viam.com/rdk/components/camera/fake 74% 0.00% ✅
go.viam.com/rdk/components/camera/ffmpeg 82% +1.49% ✅
go.viam.com/rdk/components/camera/rtsp 46% +0.88% ❌
go.viam.com/rdk/components/camera/transformpipeline 77% 0.00% ✅
go.viam.com/rdk/components/camera/videosource 34% +0.12% ❌
go.viam.com/rdk/components/encoder 57% 0.00% ➖
go.viam.com/rdk/components/encoder/ams 64% 0.00% ➖
go.viam.com/rdk/components/encoder/fake 83% 0.00% ✅
go.viam.com/rdk/components/encoder/incremental 80% 0.00% ✅
go.viam.com/rdk/components/encoder/single 86% 0.00% ✅
go.viam.com/rdk/components/gantry 56% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 87% 0.00% ✅
go.viam.com/rdk/components/gantry/oneaxis 87% 0.00% ✅
go.viam.com/rdk/components/generic 79% 0.00% ✅
go.viam.com/rdk/components/gripper 69% 0.00% ➖
go.viam.com/rdk/components/input 88% 0.00% ✅
go.viam.com/rdk/components/input/fake 94% +1.49% ✅
go.viam.com/rdk/components/input/gpio 85% 0.00% ✅
go.viam.com/rdk/components/motor 71% 0.00% ✅
go.viam.com/rdk/components/motor/dimensionengineering 65% 0.00% ➖
go.viam.com/rdk/components/motor/dmc4000 70% 0.00% ✅
go.viam.com/rdk/components/motor/fake 53% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 58% -0.61% ➖
go.viam.com/rdk/components/motor/gpiostepper 51% -0.62% ➖
go.viam.com/rdk/components/motor/tmcstepper 64% 0.00% ➖
go.viam.com/rdk/components/motor/ulnstepper 53% 0.00% ➖
go.viam.com/rdk/components/movementsensor 76% 0.00% ✅
go.viam.com/rdk/components/movementsensor/adxl345 66% 0.00% ➖
go.viam.com/rdk/components/movementsensor/cameramono 41% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 51% -3.50% ➖
go.viam.com/rdk/components/movementsensor/gpsrtk 34% +5.49% ❌
go.viam.com/rdk/components/movementsensor/mpu6050 84% 0.00% ✅
go.viam.com/rdk/components/posetracker 71% 0.00% ✅
go.viam.com/rdk/components/sensor 52% 0.00% ➖
go.viam.com/rdk/components/sensor/ultrasonic 43% 0.00% ❌
go.viam.com/rdk/components/servo 62% 0.00% ➖
go.viam.com/rdk/components/servo/gpio 72% 0.00% ✅
go.viam.com/rdk/config 79% 0.00% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 77% -3.94% ✅
go.viam.com/rdk/examples/customresources/demos/remoteserver 0% 0.00% ❌
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/internal/cloud 100% 0.00% ✅
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 71% 0.00% ✅
go.viam.com/rdk/module 76% 0.00% ✅
go.viam.com/rdk/module/modmanager 80% 0.00% ✅
go.viam.com/rdk/motionplan 71% -0.05% ✅
go.viam.com/rdk/operation 82% 0.00% ✅
go.viam.com/rdk/pointcloud 69% 0.00% ➖
go.viam.com/rdk/protoutils 49% 0.00% ❌
go.viam.com/rdk/referenceframe 72% 0.00% ✅
go.viam.com/rdk/resource 75% 0.00% ✅
go.viam.com/rdk/rimage 77% 0.00% ✅
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 75% 0.00% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 86% 0.00% ✅
go.viam.com/rdk/robot/client 82% -0.18% ✅
go.viam.com/rdk/robot/framesystem 67% 0.00% ➖
go.viam.com/rdk/robot/impl 81% -0.41% ✅
go.viam.com/rdk/robot/packages 80% 0.00% ✅
go.viam.com/rdk/robot/server 53% 0.00% ➖
go.viam.com/rdk/robot/web 64% 0.00% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol 50% 0.00% ➖
go.viam.com/rdk/services/baseremotecontrol/builtin 82% 0.00% ✅
go.viam.com/rdk/services/datamanager 65% 0.00% ➖
go.viam.com/rdk/services/datamanager/builtin 85% 0.00% ✅
go.viam.com/rdk/services/datamanager/datacapture 73% 0.00% ✅
go.viam.com/rdk/services/datamanager/datasync 0% 0.00% ❌
go.viam.com/rdk/services/mlmodel 83% 0.00% ✅
go.viam.com/rdk/services/mlmodel/tflitecpu 81% 0.00% ✅
go.viam.com/rdk/services/motion 51% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 85% 0.00% ✅
go.viam.com/rdk/services/navigation 53% 0.00% ➖
go.viam.com/rdk/services/sensors 81% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 95% 0.00% ✅
go.viam.com/rdk/services/shell 11% 0.00% ❌
go.viam.com/rdk/services/slam 93% 0.00% ✅
go.viam.com/rdk/services/slam/fake 90% 0.00% ✅
go.viam.com/rdk/services/vision 78% 0.00% ✅
go.viam.com/rdk/services/vision/builtin 72% 0.00% ✅
go.viam.com/rdk/session 97% 0.00% ✅
go.viam.com/rdk/spatialmath 84% 0.00% ✅
go.viam.com/rdk/utils 71% -0.14% ✅
go.viam.com/rdk/vision 26% 0.00% ❌
go.viam.com/rdk/vision/chess 80% 0.00% ✅
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 82% 0.00% ✅
go.viam.com/rdk/vision/odometry 60% 0.00% ➖
go.viam.com/rdk/vision/odometry/cmd 0% 0.00% ❌
go.viam.com/rdk/vision/segmentation 49% 0.00% ❌
go.viam.com/rdk/web/server 26% 0.00% ❌
Summary 66% (22006 / 33440) +0.10% ➖

edaniels
edaniels approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@edaniels edaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@bazile-clyde bazile-clyde merged commit affadb0 into viamrobotics:main Apr 25, 2023
@bazile-clyde bazile-clyde deleted the RSDK-1677 branch April 25, 2023 17:29
bazile-clyde added a commit to bazile-clyde/rdk that referenced this pull request Jan 5, 2024
@bazile-clyde
nit: switch to bool (viamrobotics#2278)
c580330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edaniels edaniels edaniels approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bazile-clyde @edaniels @viambot