Rsdk-2806: Movement sensor distance to meters #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
viambot
added
the
safe to test
viambot
added
safe to test
penguinland
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Huh! I had expected to need to change more units, but the only things that actually return their accuracy return hDOP and vDOP, which are the horizontal and vertical dilution of precision in GPS systems, and thus have nothing to do with millimeters after all! I'm surprised that this has been misnamed the whole time. 😳
Fix the 2 comments, and the rest LGTM!
| @@ -277,7 +277,7 @@ func toLinearAcceleration(data []byte) r3.Vector { | |||
| z := int(rutils.Int16FromBytesBE(data[4:6])) | |||
|
|
|||
| // The scale is +/- 2G's, but our units should be mm/sec/sec. | |||
There was a problem hiding this comment.
Change this comment to match
| @@ -479,7 +479,7 @@ func toLinearAcceleration(data []byte) r3.Vector { | |||
| z := int(rutils.Int16FromBytesLE(data[4:6])) | |||
|
|
|||
| // The default scale is +/- 2G's, but our units should be mm/sec/sec. | |||
viambot
added
safe to test
|
|
viambot
added
safe to test
stevebriskin
force-pushed
the
RSDK-2806-1
branch
from
3c67c39 to
0d9ca03
Compare
viambot
added
safe to test
|
bazile-clyde
pushed a commit
to bazile-clyde/rdk
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.