Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cfg from encoded motor structure #2252

Merged
merged 2 commits into from
May 4, 2023
Merged

Remove cfg from encoded motor structure #2252

merged 2 commits into from
May 4, 2023

Conversation

randhid
Copy link
Member

@randhid randhid commented Apr 20, 2023

And remove comments in motor_encoder_test.go

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Apr 20, 2023
@randhid randhid requested review from a team and npmenard and removed request for a team April 20, 2023 20:58
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Delta Health
go.viam.com/rdk/components/arm 64% 0.00% ➖
go.viam.com/rdk/components/arm/fake 29% 0.00% ❌
go.viam.com/rdk/components/arm/universalrobots 41% 0.00% ❌
go.viam.com/rdk/components/arm/wrapper 21% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 23% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 6% 0.00% ❌
go.viam.com/rdk/components/audioinput 41% +0.47% ❌
go.viam.com/rdk/components/base 41% 0.00% ❌
go.viam.com/rdk/components/base/agilex 63% 0.00% ➖
go.viam.com/rdk/components/base/boat 40% 0.00% ❌
go.viam.com/rdk/components/base/fake 52% 0.00% ➖
go.viam.com/rdk/components/base/wheeled 75% 0.00% ✅
go.viam.com/rdk/components/board 60% 0.00% ➖
go.viam.com/rdk/components/board/fake 40% 0.00% ❌
go.viam.com/rdk/components/board/genericlinux 20% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi 50% 0.00% ➖
go.viam.com/rdk/components/camera 62% 0.00% ➖
go.viam.com/rdk/components/camera/align 58% 0.00% ➖
go.viam.com/rdk/components/camera/fake 74% 0.00% ✅
go.viam.com/rdk/components/camera/ffmpeg 82% 0.00% ✅
go.viam.com/rdk/components/camera/rtsp 46% +0.88% ❌
go.viam.com/rdk/components/camera/transformpipeline 77% 0.00% ✅
go.viam.com/rdk/components/camera/videosource 34% 0.00% ❌
go.viam.com/rdk/components/encoder 56% 0.00% ➖
go.viam.com/rdk/components/encoder/ams 64% 0.00% ➖
go.viam.com/rdk/components/encoder/fake 83% 0.00% ✅
go.viam.com/rdk/components/encoder/incremental 80% 0.00% ✅
go.viam.com/rdk/components/encoder/single 86% 0.00% ✅
go.viam.com/rdk/components/gantry 56% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 87% 0.00% ✅
go.viam.com/rdk/components/gantry/oneaxis 87% 0.00% ✅
go.viam.com/rdk/components/generic 79% 0.00% ✅
go.viam.com/rdk/components/gripper 69% 0.00% ➖
go.viam.com/rdk/components/input 88% 0.00% ✅
go.viam.com/rdk/components/input/fake 94% +1.49% ✅
go.viam.com/rdk/components/input/gpio 85% 0.00% ✅
go.viam.com/rdk/components/motor 71% 0.00% ✅
go.viam.com/rdk/components/motor/dimensionengineering 65% 0.00% ➖
go.viam.com/rdk/components/motor/dmc4000 70% 0.00% ✅
go.viam.com/rdk/components/motor/fake 53% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 43% -15.56% ❌
go.viam.com/rdk/components/motor/gpiostepper 52% +0.62% ➖
go.viam.com/rdk/components/motor/tmcstepper 64% 0.00% ➖
go.viam.com/rdk/components/motor/ulnstepper 53% 0.00% ➖
go.viam.com/rdk/components/movementsensor 77% 0.00% ✅
go.viam.com/rdk/components/movementsensor/adxl345 66% 0.00% ➖
go.viam.com/rdk/components/movementsensor/cameramono 41% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 51% 0.00% ➖
go.viam.com/rdk/components/movementsensor/gpsrtk 28% -0.41% ❌
go.viam.com/rdk/components/movementsensor/mpu6050 84% 0.00% ✅
go.viam.com/rdk/components/posetracker 71% 0.00% ✅
go.viam.com/rdk/components/sensor 52% 0.00% ➖
go.viam.com/rdk/components/sensor/ultrasonic 43% 0.00% ❌
go.viam.com/rdk/components/servo 62% 0.00% ➖
go.viam.com/rdk/components/servo/gpio 72% 0.00% ✅
go.viam.com/rdk/config 78% 0.00% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 77% 0.00% ✅
go.viam.com/rdk/examples/customresources/demos/remoteserver 0% 0.00% ❌
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/internal/cloud 100% 0.00% ✅
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 71% 0.00% ✅
go.viam.com/rdk/module 76% 0.00% ✅
go.viam.com/rdk/module/modmanager 80% 0.00% ✅
go.viam.com/rdk/motionplan 70% -0.29% ✅
go.viam.com/rdk/operation 82% 0.00% ✅
go.viam.com/rdk/pointcloud 69% -0.07% ➖
go.viam.com/rdk/protoutils 49% 0.00% ❌
go.viam.com/rdk/referenceframe 72% 0.00% ✅
go.viam.com/rdk/resource 79% 0.00% ✅
go.viam.com/rdk/rimage 77% 0.00% ✅
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 75% 0.00% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 86% 0.00% ✅
go.viam.com/rdk/robot/client 82% 0.00% ✅
go.viam.com/rdk/robot/framesystem 67% 0.00% ➖
go.viam.com/rdk/robot/impl 82% 0.00% ✅
go.viam.com/rdk/robot/packages 80% 0.00% ✅
go.viam.com/rdk/robot/server 53% 0.00% ➖
go.viam.com/rdk/robot/web 65% +0.16% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol 50% 0.00% ➖
go.viam.com/rdk/services/baseremotecontrol/builtin 82% 0.00% ✅
go.viam.com/rdk/services/datamanager 63% 0.00% ➖
go.viam.com/rdk/services/datamanager/builtin 84% +0.49% ✅
go.viam.com/rdk/services/datamanager/datacapture 73% 0.00% ✅
go.viam.com/rdk/services/datamanager/datasync 0% 0.00% ❌
go.viam.com/rdk/services/mlmodel 82% 0.00% ✅
go.viam.com/rdk/services/mlmodel/tflitecpu 81% 0.00% ✅
go.viam.com/rdk/services/motion 51% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 85% 0.00% ✅
go.viam.com/rdk/services/navigation 53% 0.00% ➖
go.viam.com/rdk/services/sensors 81% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 95% 0.00% ✅
go.viam.com/rdk/services/shell 11% 0.00% ❌
go.viam.com/rdk/services/slam 93% 0.00% ✅
go.viam.com/rdk/services/slam/builtin 75% 0.00% ✅
go.viam.com/rdk/services/slam/fake 90% 0.00% ✅
go.viam.com/rdk/services/slam/slam_copy/config 97% 0.00% ✅
go.viam.com/rdk/services/slam/slam_copy/dataprocess 71% 0.00% ✅
go.viam.com/rdk/services/slam/slam_copy/utils 100% 0.00% ✅
go.viam.com/rdk/services/vision 78% 0.00% ✅
go.viam.com/rdk/services/vision/builtin 72% 0.00% ✅
go.viam.com/rdk/session 97% 0.00% ✅
go.viam.com/rdk/spatialmath 84% 0.00% ✅
go.viam.com/rdk/utils 72% 0.00% ✅
go.viam.com/rdk/vision 26% 0.00% ❌
go.viam.com/rdk/vision/chess 80% 0.00% ✅
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 82% 0.00% ✅
go.viam.com/rdk/vision/odometry 60% 0.00% ➖
go.viam.com/rdk/vision/odometry/cmd 0% 0.00% ❌
go.viam.com/rdk/vision/segmentation 49% 0.00% ❌
go.viam.com/rdk/web/server 26% 0.00% ❌
Summary 66% (22292 / 33925) -0.24% ➖

npmenard
npmenard reviewed Apr 24, 2023
View reviewed changes
components/motor/gpio/motor_encoder_test.go
@@ -277,7 +274,7 @@ func TestMotorEncoder1(t *testing.T) {
}

func TestMotorEncoderIncremental(t *testing.T) {
// t.Skip()
t.Skip()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why skipping the test now?

Copy link
Member Author

@randhid randhid May 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm refactoring these test in other work, was trying to unblock alan for his incremental encoder pr. That no longer applies though.

@randhid randhid requested review from penguinland, martha-johnston and npmenard and removed request for martha-johnston and npmenard May 3, 2023 14:41
@randhid randhid merged commit a17098b into viamrobotics:main May 4, 2023
randhid added a commit that referenced this pull request May 4, 2023
@randhid
Revert " Remove cfg from encoded motor structure (#2252)"
e79633c 
This reverts commit a17098b.
@randhid randhid mentioned this pull request May 4, 2023
Merged
@randhid randhid deleted the RSDK-1020 branch May 23, 2023 23:35
bazile-clyde pushed a commit to bazile-clyde/rdk that referenced this pull request Jan 5, 2024
@randhid
Remove cfg from encoded motor structure (viamrobotics#2252)
e06219d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npmenard npmenard npmenard left review comments

@martha-johnston martha-johnston martha-johnston approved these changes

@penguinland penguinland Awaiting requested review from penguinland

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@randhid @npmenard @martha-johnston @viambot