[DATA-928] Fetch tabular data in CLI via multiple requests #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
agreenb
commented
Apr 12, 2023
cli/data.go
Outdated
| if d == nil { | ||
| continue | ||
|
|
||
| fmt.Print("Downloading..") |
There was a problem hiding this comment.
Added this since this isn't parallelized/optimized, so useful to have some indication that there's progress.
viambot
added
safe to test
agreenb
commented
Apr 12, 2023
| break | ||
| } | ||
| for _, md := range mds { | ||
| mdJSONBytes, err := protojson.Marshal(md) |
There was a problem hiding this comment.
Note that this could repeat metadata, e.g. if all data came from the same capture but is split across multiple requests. What happens is that we unnecessarily create additional metadata files, but the actual data only points to metadata_idx_0. Leaving as-is for now, since this is an issue between both binary and tabular data, and becomes more complicated with parallelization.
viambot
added
safe to test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the backend sets a default limit of 50 if not passed, the TabularDataByFilter call was actually only returning a subset of documents. This fixes that bug and batches requests, since otherwise a large request will time out.
Testing
Tested locally with ~150K tabular datapoints and ensured they were all written into the ndjson with corresponding metadata.