-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-1027] complete the Orin AGX pinout #2181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ooh, hold on! I might be able to get those last 2 pins, too! |
BAM! All the non-hot, non-ground pins have at least input or output capabilities, and all but 4 of them have both. |
|
martha-johnston
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! comments are very helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of the 40 pins in the Orin's header, all are now either hot, ground, or defined in this file.
Tried with the Orin on my desk: unless mentioned in a comment above the pin, both input and output work great on them all (output checked by wiring it to an LED, input checked by wiring it to either the 3.3V rail or ground). There are 2 input-only pins, and 2 output-only pins. I think it has something to do with those 4 pins also being hooked up to the UART chip? I didn't try out digital interrupts on each pin; I assume that those work as long as the pin supports inputs (and that's not as easily checked through Viam, though I suppose I could plug an encoder into each one if anyone thinks that's an important test to do).
I didn't document which pins are high by default at bootup and which are low by default, though that could be useful information (when I wired up the base-in-the-world, I accidentally used some pins that were high by default for the motors, and when the Orin rebooted that motor would start spinning out of control). OTOH, that's information you can probably get from NVidia without us copying it over, and if we did copy it over, I don't even know where I'd put it.
Working on this was how I discovered the problems behind #2180. (The tests I describe above were performed after that PR was merged and this branch was rebased onto the latest main branch. Before then, none of the inputs worked.)