RSDK-2240 Remove Temp Endpoints from SLAM #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
jeremyrhyde
commented
Mar 30, 2023
| @@ -115,15 +115,15 @@ func TestClientWorkingService(t *testing.T) { | |||
| test.That(t, spatial.PoseAlmostEqual(poseSucc, pose), test.ShouldBeTrue) | |||
| test.That(t, componentRef, test.ShouldEqual, componentRefSucc) | |||
|
|
|||
| // test get point cloud map stream | |||
There was a problem hiding this comment.
Optional removal, I'm in favor to keep pattern with server tests
There was a problem hiding this comment.
this is fine, we have a ticket to make server tests into individual t.runs, which should probably include these tests too
There was a problem hiding this comment.
I agree with john. Lets address client tests not being in t.Runs in the ticket he linked.
There was a problem hiding this comment.
[note to self] we took out the word "stream" everywhere that we aren't specifically testing the streaming aspect of the api
|
JohnN193
approved these changes
Mar 30, 2023
nicksanford
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Approved, assuming it is not merged until https://github.com/viamrobotics/app/pull/1358 is on production
EshaMaharishi
approved these changes
Mar 31, 2023
| @@ -115,15 +115,15 @@ func TestClientWorkingService(t *testing.T) { | |||
| test.That(t, spatial.PoseAlmostEqual(poseSucc, pose), test.ShouldBeTrue) | |||
| test.That(t, componentRef, test.ShouldEqual, componentRefSucc) | |||
|
|
|||
| // test get point cloud map stream | |||
There was a problem hiding this comment.
[note to self] we took out the word "stream" everywhere that we aren't specifically testing the streaming aspect of the api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the last links to the temporary endpoints created during Map Representation. These include:
The only place these still existed was in the
server.gofile and its associated tests, although a few comments were also updated in theclient_test.go.Predominantly, the only places stream still exists are in the client/server tests which are comparing testing unary and streaming calls and the comments in
slam.go/grpchelper.goassociated with the concatenation functions.Examples:
If you believe these should change leave a comment below
JIRA Ticket: https://viam.atlassian.net/browse/RSDK-2240