[RSDK-2496] Directly refresh webservice subtype services before modular resource loading #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
Otterverse
commented
Mar 28, 2023
Comment on lines
+770
to
771
| // Refresh causes the web service to reload it's subtype service maps from the actual robot resources. | ||
| func (r *localRobot) Refresh(ctx context.Context) error { |
There was a problem hiding this comment.
Should I not be using this function? It felt like it fit in the paradigm, and my thinking was if MORE stuff needs to be refreshed here later, it can be added.
There was a problem hiding this comment.
@cheukt I think git said you were responsible for this line/func, so wanted to double check if you think this PR is the correct way to handle this or not. Thanks!
|
zaporter-work
approved these changes
Mar 29, 2023
NP, will hold off on merging until then. @zaporter-work Let me know if this becomes a blocker before then. |
cheukt
approved these changes
Mar 31, 2023
Comment on lines
+770
to
771
| // Refresh causes the web service to reload it's subtype service maps from the actual robot resources. | ||
| func (r *localRobot) Refresh(ctx context.Context) error { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://viam.atlassian.net/browse/RSDK-2496 describes the problem, but the short example is that it was impossible to use
motor.Stop()during something likeNewBase()This should fix that issue, but may not be the best approach. (See inline notes.)