Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-1865-add-map-rep-methods-to-fake-slam #1964

Merged
merged 10 commits into from
Mar 6, 2023
Merged

RSDK-1865-add-map-rep-methods-to-fake-slam #1964

merged 10 commits into from
Mar 6, 2023

Conversation

nicksanford
Copy link
Member

@nicksanford nicksanford commented Mar 2, 2023 •
edited
Loading

Ticket

  • Implement GetPosition for fake slam
  • Implement GetPointCloudMapStream for fake slam
  • Implement GetInternalStateStream for fake slam

@viambot viambot added viam-org Is part of the viamrobotics organization. safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 2, 2023
@nicksanford nicksanford marked this pull request as ready for review March 2, 2023 19:47
tessavitabile
tessavitabile approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@tessavitabile tessavitabile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do you know why there are changes to package-lock.json?

JohnN193
JohnN193 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@JohnN193 JohnN193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small optional nit

@nicksanford
Copy link
Member Author

LGTM, but do you know why there are changes to package-lock.json?

I think b/c I failed to resolve git diffs correctly in an earlier PR

jeremyrhyde
jeremyrhyde suggested changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@jeremyrhyde jeremyrhyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass with some optimizations/ testing suggestions

jeremyrhyde
jeremyrhyde reviewed Mar 3, 2023
View reviewed changes
Copy link
Contributor

@jeremyrhyde jeremyrhyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some updates

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 3, 2023
@nicksanford nicksanford requested a review from jeremyrhyde March 3, 2023 16:40
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 3, 2023
jeremyrhyde
jeremyrhyde approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@jeremyrhyde jeremyrhyde left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after final nil addition

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 6, 2023
nicksanford and others added 7 commits March 6, 2023 17:45
@nicksanford
fix lint
7be2287
@nicksanford @jeremyrhyde
Update services/slam/fake/slam_test.go
51780e7 
Co-authored-by: jeremyrhyde <34897732+jeremyrhyde@users.noreply.github.com>
@nicksanford @jeremyrhyde
Update services/slam/fake/slam_test.go
b639edc 
Co-authored-by: jeremyrhyde <34897732+jeremyrhyde@users.noreply.github.com>
@nicksanford
wip
90c0c27
@nicksanford
respond to feedback
3ed6bf9
@nicksanford
Respond to feedback
4e4b763
@nicksanford
Fix lint
ab8136d
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Code Coverage

Note: merge base coverage results not available, comparing against closest d204173~1=(9be8e4b) instead

Package Line Rate Delta Health
go.viam.com/rdk/components/arm 60% 0.00% ➖
go.viam.com/rdk/components/arm/universalrobots 42% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 6% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 6% 0.00% ❌
go.viam.com/rdk/components/audioinput 54% 0.00% ➖
go.viam.com/rdk/components/base 62% 0.00% ➖
go.viam.com/rdk/components/base/agilex 62% 0.00% ➖
go.viam.com/rdk/components/base/boat 41% 0.00% ❌
go.viam.com/rdk/components/base/wheeled 75% 0.00% ✅
go.viam.com/rdk/components/board 66% 0.00% ➖
go.viam.com/rdk/components/board/arduino 10% 0.00% ❌
go.viam.com/rdk/components/board/fake 39% 0.00% ❌
go.viam.com/rdk/components/board/genericlinux 31% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi 50% 0.00% ➖
go.viam.com/rdk/components/camera 64% 0.00% ➖
go.viam.com/rdk/components/camera/align 64% 0.00% ➖
go.viam.com/rdk/components/camera/fake 64% 0.00% ➖
go.viam.com/rdk/components/camera/ffmpeg 76% -1.43% ✅
go.viam.com/rdk/components/camera/rtsp 59% 0.00% ➖
go.viam.com/rdk/components/camera/transformpipeline 78% 0.00% ✅
go.viam.com/rdk/components/camera/videosource 34% 0.00% ❌
go.viam.com/rdk/components/encoder 4% 0.00% ❌
go.viam.com/rdk/components/encoder/fake 76% 0.00% ✅
go.viam.com/rdk/components/gantry 59% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 84% 0.00% ✅
go.viam.com/rdk/components/gantry/oneaxis 86% 0.00% ✅
go.viam.com/rdk/components/generic 82% 0.00% ✅
go.viam.com/rdk/components/gripper 67% 0.00% ➖
go.viam.com/rdk/components/input 87% 0.00% ✅
go.viam.com/rdk/components/input/fake 86% 0.00% ✅
go.viam.com/rdk/components/input/gpio 84% 0.00% ✅
go.viam.com/rdk/components/motor 76% 0.00% ✅
go.viam.com/rdk/components/motor/dimensionengineering 63% 0.00% ➖
go.viam.com/rdk/components/motor/dmc4000 69% 0.00% ➖
go.viam.com/rdk/components/motor/fake 57% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 65% +0.42% ➖
go.viam.com/rdk/components/motor/gpiostepper 56% -0.59% ➖
go.viam.com/rdk/components/motor/tmcstepper 62% 0.00% ➖
go.viam.com/rdk/components/motor/ulnstepper 52% 0.00% ➖
go.viam.com/rdk/components/movementsensor 75% 0.00% ✅
go.viam.com/rdk/components/movementsensor/cameramono 45% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 37% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsrtk 29% 0.00% ❌
go.viam.com/rdk/components/posetracker 84% 0.00% ✅
go.viam.com/rdk/components/sensor 66% 0.00% ➖
go.viam.com/rdk/components/sensor/ultrasonic 31% 0.00% ❌
go.viam.com/rdk/components/servo 66% 0.00% ➖
go.viam.com/rdk/components/servo/gpio 71% 0.00% ✅
go.viam.com/rdk/config 77% 0.00% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 78% 0.00% ✅
go.viam.com/rdk/examples/customresources/demos/complexmodule 0% 0.00% ❌
go.viam.com/rdk/examples/customresources/demos/remoteserver 0% 0.00% ❌
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 70% 0.00% ✅
go.viam.com/rdk/module 65% 0.00% ➖
go.viam.com/rdk/module/modmanager 79% 0.00% ✅
go.viam.com/rdk/motionplan 69% +0.31% ➖
go.viam.com/rdk/operation 82% 0.00% ✅
go.viam.com/rdk/pointcloud 73% 0.00% ✅
go.viam.com/rdk/protoutils 49% 0.00% ❌
go.viam.com/rdk/referenceframe 73% 0.00% ✅
go.viam.com/rdk/registry 89% 0.00% ✅
go.viam.com/rdk/resource 84% 0.00% ✅
go.viam.com/rdk/rimage 78% 0.00% ✅
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 75% 0.00% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 86% -0.91% ✅
go.viam.com/rdk/robot/client 81% 0.00% ✅
go.viam.com/rdk/robot/framesystem 65% 0.00% ➖
go.viam.com/rdk/robot/impl 81% +0.21% ✅
go.viam.com/rdk/robot/packages 78% 0.00% ✅
go.viam.com/rdk/robot/server 55% 0.00% ➖
go.viam.com/rdk/robot/web 62% 0.00% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol 71% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol/builtin 55% 0.00% ➖
go.viam.com/rdk/services/baseremotecontrol 71% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol/builtin 81% 0.00% ✅
go.viam.com/rdk/services/datamanager 75% 0.00% ✅
go.viam.com/rdk/services/datamanager/builtin 78% 0.00% ✅
go.viam.com/rdk/services/datamanager/datacapture 74% 0.00% ✅
go.viam.com/rdk/services/datamanager/datasync 0% 0.00% ❌
go.viam.com/rdk/services/motion 60% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 88% 0.00% ✅
go.viam.com/rdk/services/navigation 54% 0.00% ➖
go.viam.com/rdk/services/sensors 74% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 97% 0.00% ✅
go.viam.com/rdk/services/shell 25% 0.00% ❌
go.viam.com/rdk/services/slam 84% +2.01% ✅
go.viam.com/rdk/services/slam/builtin 70% +0.70% ✅
go.viam.com/rdk/services/slam/fake 87% +8.74% ✅
go.viam.com/rdk/services/vision 79% 0.00% ✅
go.viam.com/rdk/services/vision/builtin 74% 0.00% ✅
go.viam.com/rdk/session 97% 0.00% ✅
go.viam.com/rdk/spatialmath 84% 0.00% ✅
go.viam.com/rdk/subtype 92% 0.00% ✅
go.viam.com/rdk/utils 72% 0.00% ✅
go.viam.com/rdk/vision 26% 0.00% ❌
go.viam.com/rdk/vision/chess 80% 0.00% ✅
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 82% 0.00% ✅
go.viam.com/rdk/vision/odometry 60% 0.00% ➖
go.viam.com/rdk/vision/odometry/cmd 0% 0.00% ❌
go.viam.com/rdk/vision/segmentation 49% 0.00% ❌
go.viam.com/rdk/web/server 26% 0.00% ❌
Summary 65% (22350 / 34173) +0.11% ➖

@nicksanford nicksanford merged commit b731a81 into viamrobotics:main Mar 6, 2023
ehhong pushed a commit to ehhong/rdk that referenced this pull request Mar 8, 2023
@nicksanford @jeremyrhyde @ehhong
RSDK-1865-add-map-rep-methods-to-fake-slam (viamrobotics#1964)
464d971 
Co-authored-by: jeremyrhyde <34897732+jeremyrhyde@users.noreply.github.com>
zaporter-work pushed a commit to zaporter-work/rdk that referenced this pull request Mar 8, 2023
@nicksanford @jeremyrhyde @zaporter-work
RSDK-1865-add-map-rep-methods-to-fake-slam (viamrobotics#1964)
5afcf23 
Co-authored-by: jeremyrhyde <34897732+jeremyrhyde@users.noreply.github.com>
biotinker pushed a commit to biotinker/robotcore that referenced this pull request Mar 16, 2023
@nicksanford @jeremyrhyde @biotinker
RSDK-1865-add-map-rep-methods-to-fake-slam (viamrobotics#1964)
024fa82 
Co-authored-by: jeremyrhyde <34897732+jeremyrhyde@users.noreply.github.com>
@nicksanford nicksanford mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyrhyde jeremyrhyde jeremyrhyde approved these changes

@tessavitabile tessavitabile tessavitabile approved these changes

@JohnN193 JohnN193 JohnN193 approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone viam-org Is part of the viamrobotics organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicksanford @tessavitabile @jeremyrhyde @JohnN193 @viambot