Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HTTP versions of RestartChecker, Config Reader, Log Writer #1959

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Remove HTTP versions of RestartChecker, Config Reader, Log Writer #1959

merged 1 commit into from
Mar 2, 2023

Conversation

AdamMagaluk
Copy link
Contributor

@AdamMagaluk AdamMagaluk commented Mar 2, 2023 •
edited
Loading

The http -> grpc migration is long done now and those code paths are no longer needed.

@viambot viambot added viam-org Is part of the viamrobotics organization. safe to test This pull request is marked safe to test from a trusted zone labels Mar 2, 2023
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 2, 2023
@AdamMagaluk AdamMagaluk changed the title WIP - Remove HTTP Remove HTTP versions of RestartChecker, Config Reader, Log Writer Mar 2, 2023
@cheukt
Copy link
Member

cheukt commented Mar 2, 2023

have you tested this manually?

@AdamMagaluk
Copy link
Contributor Author

Yeah just tested locally with a new device. No issues with restart, logs, or getting config.

Still one test failing that im looking into.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 2, 2023
AdamMagaluk
AdamMagaluk commented Mar 2, 2023
View reviewed changes
config/reader.go
if err != nil {
var urlErr *url.Error
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gRPC will never return a url.Error so the check (!errors.As(err, &urlErr) || urlErr.Temporary()) is meaningless. To avoid the test now failing i disabled cert reading on the calls from the test.

cheukt
cheukt approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdamMagaluk
Remove HTTP versions of RestartChecker, Config Reader, Log Writer
d57dac5 
The http -> grpc migration is long done now and those code paths are
no longer needed.
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Mar 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Code Coverage

Package Line Rate Delta Health
go.viam.com/rdk/components/arm 60% 0.00% ➖
go.viam.com/rdk/components/arm/universalrobots 42% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 6% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 6% 0.00% ❌
go.viam.com/rdk/components/audioinput 54% 0.00% ➖
go.viam.com/rdk/components/base 62% 0.00% ➖
go.viam.com/rdk/components/base/agilex 62% 0.00% ➖
go.viam.com/rdk/components/base/boat 41% 0.00% ❌
go.viam.com/rdk/components/base/wheeled 75% 0.00% ✅
go.viam.com/rdk/components/board 66% 0.00% ➖
go.viam.com/rdk/components/board/arduino 10% 0.00% ❌
go.viam.com/rdk/components/board/fake 39% 0.00% ❌
go.viam.com/rdk/components/board/genericlinux 34% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi 50% 0.00% ➖
go.viam.com/rdk/components/camera 64% 0.00% ➖
go.viam.com/rdk/components/camera/align 64% 0.00% ➖
go.viam.com/rdk/components/camera/fake 64% 0.00% ➖
go.viam.com/rdk/components/camera/ffmpeg 77% +1.43% ✅
go.viam.com/rdk/components/camera/rtsp 59% 0.00% ➖
go.viam.com/rdk/components/camera/transformpipeline 78% 0.00% ✅
go.viam.com/rdk/components/camera/videosource 34% 0.00% ❌
go.viam.com/rdk/components/encoder 4% 0.00% ❌
go.viam.com/rdk/components/encoder/fake 76% 0.00% ✅
go.viam.com/rdk/components/gantry 59% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 84% 0.00% ✅
go.viam.com/rdk/components/gantry/oneaxis 86% 0.00% ✅
go.viam.com/rdk/components/generic 82% 0.00% ✅
go.viam.com/rdk/components/gripper 67% 0.00% ➖
go.viam.com/rdk/components/gripper/trossen 24% 0.00% ❌
go.viam.com/rdk/components/input 87% 0.00% ✅
go.viam.com/rdk/components/input/gpio 84% 0.00% ✅
go.viam.com/rdk/components/motor 76% 0.00% ✅
go.viam.com/rdk/components/motor/dimensionengineering 63% 0.00% ➖
go.viam.com/rdk/components/motor/dmc4000 69% 0.00% ➖
go.viam.com/rdk/components/motor/fake 57% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 64% -0.43% ➖
go.viam.com/rdk/components/motor/gpiostepper 57% 0.00% ➖
go.viam.com/rdk/components/motor/tmcstepper 62% 0.00% ➖
go.viam.com/rdk/components/motor/ulnstepper 52% 0.00% ➖
go.viam.com/rdk/components/movementsensor 75% 0.00% ✅
go.viam.com/rdk/components/movementsensor/cameramono 45% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 37% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsrtk 29% 0.00% ❌
go.viam.com/rdk/components/posetracker 84% 0.00% ✅
go.viam.com/rdk/components/sensor 66% 0.00% ➖
go.viam.com/rdk/components/sensor/ultrasonic 31% 0.00% ❌
go.viam.com/rdk/components/servo 66% 0.00% ➖
go.viam.com/rdk/components/servo/gpio 71% 0.00% ✅
go.viam.com/rdk/config 77% +2.39% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 79% 0.00% ✅
go.viam.com/rdk/examples/customresources/demos/complexmodule 0% 0.00% ❌
go.viam.com/rdk/examples/customresources/demos/remoteserver 0% 0.00% ❌
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 70% 0.00% ✅
go.viam.com/rdk/module 65% 0.00% ➖
go.viam.com/rdk/module/modmanager 79% 0.00% ✅
go.viam.com/rdk/motionplan 69% -0.31% ➖
go.viam.com/rdk/operation 82% 0.00% ✅
go.viam.com/rdk/pointcloud 73% +0.08% ✅
go.viam.com/rdk/protoutils 49% 0.00% ❌
go.viam.com/rdk/referenceframe 72% 0.00% ✅
go.viam.com/rdk/registry 89% 0.00% ✅
go.viam.com/rdk/resource 84% 0.00% ✅
go.viam.com/rdk/rimage 78% 0.00% ✅
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 75% 0.00% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 86% 0.00% ✅
go.viam.com/rdk/robot/client 81% 0.00% ✅
go.viam.com/rdk/robot/framesystem 65% 0.00% ➖
go.viam.com/rdk/robot/impl 81% 0.00% ✅
go.viam.com/rdk/robot/packages 78% 0.00% ✅
go.viam.com/rdk/robot/server 55% +0.59% ➖
go.viam.com/rdk/robot/web 62% 0.00% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol 71% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol/builtin 55% 0.00% ➖
go.viam.com/rdk/services/baseremotecontrol 71% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol/builtin 81% 0.00% ✅
go.viam.com/rdk/services/datamanager 75% 0.00% ✅
go.viam.com/rdk/services/datamanager/builtin 78% 0.00% ✅
go.viam.com/rdk/services/datamanager/datacapture 74% 0.00% ✅
go.viam.com/rdk/services/datamanager/datasync 0% 0.00% ❌
go.viam.com/rdk/services/motion 60% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 88% 0.00% ✅
go.viam.com/rdk/services/navigation 54% 0.00% ➖
go.viam.com/rdk/services/sensors 74% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 97% 0.00% ✅
go.viam.com/rdk/services/shell 25% 0.00% ❌
go.viam.com/rdk/services/slam 78% 0.00% ✅
go.viam.com/rdk/services/slam/builtin 70% 0.00% ➖
go.viam.com/rdk/services/slam/fake 80% 0.00% ✅
go.viam.com/rdk/services/vision 80% 0.00% ✅
go.viam.com/rdk/services/vision/builtin 74% 0.00% ✅
go.viam.com/rdk/session 97% 0.00% ✅
go.viam.com/rdk/spatialmath 84% 0.00% ✅
go.viam.com/rdk/subtype 92% 0.00% ✅
go.viam.com/rdk/utils 72% -0.18% ✅
go.viam.com/rdk/vision 26% 0.00% ❌
go.viam.com/rdk/vision/chess 80% 0.00% ✅
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 82% 0.00% ✅
go.viam.com/rdk/vision/odometry 60% 0.00% ➖
go.viam.com/rdk/vision/odometry/cmd 0% 0.00% ❌
go.viam.com/rdk/vision/segmentation 49% 0.00% ❌
go.viam.com/rdk/web/server 26% +1.75% ❌
Summary 65% (22107 / 33888) +0.13% ➖

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Warning changing any of the following functions will break code samples on app if an api for these function changes please contact the fleet team

component function
base IsMoving
board GPIOPinByName
camera Properties
motor IsMoving
sensor Readings
servo Position
arm EndPosition
audio MediaProperties
gantry Lengths
gripper IsMoving
input_controller Controls
movement_sensor LinearAcceleration
pose_tracker Poses
motion GetPose
vision DetectorNames

@AdamMagaluk AdamMagaluk merged commit d22c71f into viamrobotics:main Mar 2, 2023
@AdamMagaluk AdamMagaluk deleted the cleanup-http branch March 2, 2023 21:26
biotinker pushed a commit to biotinker/robotcore that referenced this pull request Mar 16, 2023
@AdamMagaluk @biotinker
Remove HTTP versions of RestartChecker, Config Reader, Log Writer (vi…
3616579 
…amrobotics#1959)

The http -> grpc migration is long done now and those code paths are no longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheukt cheukt cheukt approved these changes

@stevebriskin stevebriskin Awaiting requested review from stevebriskin

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone viam-org Is part of the viamrobotics organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamMagaluk @cheukt @viambot